[SOLVED] how to fix these problems...??

[clown[NOR]]

i added my test site to the beta test forum, and one of the replies i got was:

 

Well, your login is very easy to bypass, and you're open to XSS in your entries. You'll notice that I entered a test movie with some javascript in the review that pops up in the first screen. Also, you're open to SQL injection in your ORDER BY clause when you sort by something.

 

how can i fix this?

 

[rpadilla]

You'll need to read more about security and stuff, its a bit complicated,

best way is get a free forum script and make sure its updated.

 

cheers

[clown[NOR]]

well... this was for my "My Favorite Movie" script =) hehe.... but anyway...

 

could something like this done the trick agains the SQL injection? done some google searches on that and on wikipedia.org

 

they used this exact code (only change is the variable and table name)

 

$result = mysql_query
(
	"select * from mfm_users where username = '"
.
	mysql_real_escape_string($mfm_USER)
.
	"'"
);

[gluck]

Google SQL Injection

[clown[NOR]]

you didnt read my post did you gluck?

well... this was for my "My Favorite Movie" script =) hehe.... but anyway...

 

could something like this done the trick agains the SQL injection? done some google searches on that and on wikipedia.org

 

they used this exact code (only change is the variable and table name)

 

[obsidian]

Clown, to make sure that someone has something valid in there, all you really have to do is something like this:

<?php
if (isset($_POST['username']) && isset($_POST['password'])) {
  $user = trim($_POST['username']);
  $pass = trim($_POST['password']);
  if (empty($user) || empty($pass)) {
    // error out - empty strings being submitted
  } else {
    $q = "SELECT * FROM userTable WHERE username = '" . mysql_real_escape_string($user) . "' AND password = MD5('" . mysql_real_escape_string($pass) . "')";
    // Check your results here
  }
}
?>

 

Hope this helps.

[clown[NOR]]

yup it did... had made something simular ... but that one looked nicer, and had less lines... so I'm using it...thanks for the help