sql query in a if statement?!?

[illuz1on]

Hey can anyone spot the error in here?

 

I want it to make it so that if q="" then it doesnt execute the SQL query

 

<?
if( $_GET["action"] == "clubs" ){
$q1 = "clubs";
} elseif( $_GET["action"] == "bars" ){
$q1 = "bars";
} elseif( $_GET["action"] == "lounges" ){
$q1 = "lounges";
} elseif( $_GET["action"] == "events" ){
$q1 = "events";
}else {
$q1 = "";
echo "Click on one of the above links to see a listing of some of the hottest places in town!";
}
?>
<?
if ( !q ) {
echo "Click on one of the above links to see a listing of some of the hottest places in town!";
}
else {

$getnews = mysql_query("select * from $q1");
while($r=mysql_fetch_array($getnews)){
extract($r);
echo("<div class=\"blue\"><b>$name - $id</b></div>
<div class=\"sdesc\">$music</div>
<hr>");
}
?>

[trq]

if ( !q ) {

 

Should be...

 

if ($q == "") {

 

I'm sorry though, but most of your code is redundant.

[illuz1on]

what do you mean?

[MadTechie]

Redundant code is a computer programming term for code that is executed but has no effect on the output of a program (dead code is the term applied to code that is never executed).

[trq]

Most of it is not needed.

 

<?php

  if (isset($_GET["action"])) {
    if ($result = mysql_query("SELECT * FROM " . mysql_real_escape_string($_GET['action']));
      if (mysql_num_rows($result)) {
        while($row = mysql_fetch_array($result)) {
          extract($row);
          echo "<div class=\"blue\"><b>$name - $id</b></div><div class=\"sdesc\">$music</div><hr>";
        }
      }
    }
  } else {
    echo "Click on one of the above links to see a listing of some of the hottest places in town!";
  }

?>

 

My code will do exactly the same thing + it has some form of error handling.