[SOLVED] Add Extension

[SkyRanger]

How would I be able to add more extensions to this:

 

if ($_FILES['imagefile']['type'] == "image/gif"){ 
copy ($_FILES['imagefile']['tmp_name'], "files/".$_FILES['imagefile']['name']) 
} 

[sw0o0sh]

um, a function or a very long OR statement...

 

<?PHP
function is_image($input){

switch($input){

case "image/gif":
return true;
break;

case "image/jpeg":
return true;
break;

default:
return false; // Not an image, or at least didnt match what you made availab le
break;

}

}

if (is_image($_FILES['imagefile']['type']) == TRUE){ 

copy ($_FILES['imagefile']['tmp_name'], "files/".$_FILES['imagefile']['name']);
} 

?>

 

That's how I'd approach it. Not sure if theres a cleaner / shorter method.

[SkyRanger]

Not letting me call the function:

 

Fatal error: Call to undefined function is_image() in membersfiles.php on line 71

[SkyRanger]

~bump~

[sw0o0sh]

then you didnt declare the function i included >_>

[SkyRanger]

Yeah i declared it, my head is full of function problems tonight, got 90% of them fixed, will fix the other 10% in the morning.  Thanks sw0o0sh.

 

 

[sw0o0sh]

So wait, is your problem fixed or do you still need help? It would only say that error if that function did not exist at least ABOVE the area where the function is being called.

[SkyRanger]

No the problem is still there i put the:

 

function is_image($input){

switch($input){

case "image/gif":
return true;
break;

case "image/jpeg":
return true;
break;

default:
return false; // Not an image, or at least didnt match what you made availab le
break;

}

}

 

Into my functions.php doc with the rest of my garbage...lol

 

I put:

I replaced:

if ($_FILES['imagefile']['type'] == "image/gif"){ 
copy ($_FILES['imagefile']['tmp_name'], "files/images/".$_FILES['imagefile']['name']) 

or die ("Could not copy"); 
echo "<br>"; 


with:
   
if (is_image($_FILES['imagefile']['type']) == TRUE){ 
copy ($_FILES['imagefile']['tmp_name'], "files/images/".$_FILES['imagefile']['name']);

or die ("Could not copy"); 
echo "<br>"; 


} -- Is farther down around rest of code

 

I must have missed a step somewhere.

 

It is 12:30am here so eyes are closing will look at it again in morning and will set as Solved if this works.

 

[SkyRanger]

Ok, I am getting a new error now:

 

Parse error: syntax error, unexpected T_LOGICAL_OR in /home/prodco/public_html/members/membersfiles.php on line 81


which is:

    or die ("Could not copy"); 

This is what I have so far:

if(isset( $Submit ))
{
//If the Submitbutton was pressed do:

if (is_image($_FILES['imagefile']['type']) == TRUE){ 
copy ($_FILES['imagefile']['tmp_name'], "files/images/".$_FILES['imagefile']['name']);

    or die ("Could not copy"); 
echo "<br>"; 
     
	$filename = $_FILES['imagefile']['name'];
	$owner = $logged;

	include "inc/dbinfo.inc.php";
// database connect script.
$connection=mysql_connect ("$dblocation", "$dbusername", "$dbpassword") or die ('I cannot connect to the database because: ' . mysql_error());
        mysql_select_db ("$dbname");

$sql = "INSERT INTO memberimages VALUES ('', '".$filename."', '".$owner."', '".$desc."')";
$result = mysql_query($sql) or die ('I could not add information to the database because ' . mysql_error());

		    
        echo "Name: ".$_FILES['imagefile']['name']."<br>"; 
        echo "Size: ".$_FILES['imagefile']['size']."<br>"; 
        echo "Type: ".$_FILES['imagefile']['type']."<br>"; 
        echo "Image Upload Completed"; 
        } 
	else {
            echo "<br><br>";
            echo "Could Not Copy, Wrong Filetype (".$_FILES['imagefile']['name'].")<br>";
        }
} 

[AndyB]

remove the ; from the preceding line, i.e. copy(.....) or die(...);

[SkyRanger]

That fixed it, thanks AndyB

[SkyRanger]

Found a problem,  I tried adding 2 more case switches but they are not working:

 

case "image/png":
return true;
break;

case "image/jpg":
return true;
break;

 

Not sure what the problem is.

[SkyRanger]

~bump~

[SkyRanger]

~bump~

[SkyRanger]

I added PNG and JPG to my functions.php but when I try to upload a file with either one of these extension it says no allowed.

 

function is_image($input){

switch($input){

case "image/gif":
return true;
break;

case "image/jpeg":
return true;
break;

case "image/png": //Added for allow
return true;
break;

case "image/jpg": //Added for allow
return true;
break;

default:
return false; // Not an image, or at least didnt match what you made available
break;

}

}

 

Why is this not allowed.

 

Here is the form code:

 

<form name="form1" method="post" action="" enctype="multipart/form-data">
		<input name="desc" type="text" value="" size="30" />
<input type="file" name="imagefile">
<br>
<input type="submit" name="Submit" value="Submit"> 
<?
if(isset( $Submit ))
{
//If the Submitbutton was pressed do:

if (is_image($_FILES['imagefile']['type']) == TRUE){ 
copy ($_FILES['imagefile']['tmp_name'], "files/images/".$_FILES['imagefile']['name'])

    or die ("Could not copy"); 
echo "<br>"; 
    
	$uploaddate = date("l F j, Y"); 
	$filename = $_FILES['imagefile']['name'];
	$owner = $logged;

	include "inc/dbinfo.inc.php";
// database connect script.
$connection=mysql_connect ("$dblocation", "$dbusername", "$dbpassword") or die ('I cannot connect to the database because: ' . mysql_error());
        mysql_select_db ("$dbname");

$sql = "INSERT INTO memberimages VALUES ('', '".$filename."', '".$owner."', '".$desc."', '".$uploaddate."')";
$result = mysql_query($sql) or die ('I could not add information to the database because ' . mysql_error());

		    
        echo "Name: ".$_FILES['imagefile']['name']."<br>"; 
        echo "Size: ".$_FILES['imagefile']['size']."<br>"; 
        echo "Type: ".$_FILES['imagefile']['type']."<br>"; 
        echo "Image Upload Completed"; 
        } 
	else {
            echo "<br><br>";
            echo "Could Not Copy, Wrong Filetype (".$_FILES['imagefile']['name'].")<br>";
        }
} 
?></form>

[SkyRanger]

Anybody able to tell my why when I upload an image and the following to switch cases are in my functions.php file :

 

case "image/png": //Added for allow
return true;
break;

case "image/jpg": //Added for allow
return true;
break;

 

is saying that the image is false?

[MadTechie]

erm. simplely they won't return false, and bumping like that is a pain, i sometimes wait a day before bumping atleast an hour but 3 hours works well as a different set of people are normally online

[SkyRanger]

Sorry MadTechie, was getting frustrated and working on 3 different codes at the same time, usually I wait for a couple of hours before bumping guess I got to impatient.  Will have to double check code to find out why they are doing that, maybe I missed something.  Thanks

[MadTechie]

ok for testing

 

function is_image($input){

switch($input){

case "image/gif":
return true;
break;

case "image/jpeg":
return true;
break;

case "image/png": //Added for allow
return true;
break;

case "image/jpg": //Added for allow
return true;
break;

default:
die($input);// ADD THIS
return false; // Not an image, or at least didnt match what you made available
break;

}

}

 

this should tell you whats going wrong

[SkyRanger]

Working now...lol, I added that code and found the problem.  It was a coder error.  Thanks MadTechie

[MadTechie]

welcome,