[SOLVED] upload script

[lewis987]

ok i have an upload script:

 

<?php
if (($_FILES["file"]["type"] == "image/gif")
|| ($_FILES["file"]["type"] == "image/pjpeg")
&& ($_FILES["file"]["size"] < 2000000))
  {
  if ($_FILES["file"]["error"] > 0)
    {
    echo "Return Code: " . $_FILES["file"]["error"] . "<br />";
    }
  else
    {
    echo "Upload: " . $_FILES["file"]["name"] . "<br />";
    echo "Type: " . $_FILES["file"]["type"] . "<br />";
    echo "Size: " . ($_FILES["file"]["size"] / 1024) . " Kb<br />";
    echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br />";
    if (file_exists("upload/" . $_FILES["file"]["name"]))
      {
      echo $_FILES["file"]["name"] . " already exists. ";
      }
    else
      {
      move_uploaded_file($_FILES["file"]["tmp_name"],
      "upload/" . $_FILES["file"]["name"]);
      echo "Stored in: " . "upload/" . $_FILES["file"]["name"];
      }
    }
  }
else
  {
  echo "Invalid file";
  }
?>

 

however, when i test it, it fails straight away, anyone got a remedy?

 

thanks!

[jitesh]

Post the form also

[lewis987]

ok heres the form:

<form action="upload.php" method="get"
enctype="multipart/form-data">
<label for="file">Filename:</label>
<input type="file" name="file" id="file" /> 
<br />
<input type="submit" name="submit" value="Submit" />
</form>

[jitesh]

chmod("upload", 777);

move_uploaded_file($_FILES["file"]["tmp_name"],

      "upload/" . $_FILES["file"]["name"]);

 

[igor berger]

CHMOD 766 for upload dir no no no 777 is securety risk, will allow to execute the file!!!!

 

Make sure the upload is above the dir you running the script in, if not use absolute path!

/home/usernamer/etc...

or you have your own server maybe

C:\\ not sure

Use enviromental variable to look up your documer root! $Server['document_root'] check syntax

www.php.net

[lewis987]

that makes no difference, i get invalid file when i run the script, like its not processing the upload.php file fully

[jitesh]

if(in_array($_FILES["file"]["type"],array('image/pjpeg','image/gif')) and ($_FILES["file"]["size"] < 2000000)){

 

}

[lewis987]

still no luck 

[igor berger]

Why don't you post the url to your no luck.

Maybe one of us can pick up the error!

[lewis987]

ok, it will be on between 6PM and 9PM (GMT) tomorrow

[JakeTheSnake3.0]

Two issues...

 

1) You needed brackets around your image type condition.... (gif || jpeg) && filesize....

2) You had pjpeg instead of jpeg

 

<?php
if ((($_FILES["file"]["type"] == "image/gif") || ($_FILES["file"]["type"] == "image/jpeg")) && ($_FILES["file"]["size"] < 2000000)) {
if ($_FILES["file"]["error"] > 0) {
	echo "Return Code: " . $_FILES["file"]["error"] . "<br />";
} else {
	echo "Upload: " . $_FILES["file"]["name"] . "<br />";
	echo "Type: " . $_FILES["file"]["type"] . "<br />";
	echo "Size: " . ($_FILES["file"]["size"] / 1024) . " Kb<br />";
	echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br />";
	if (file_exists("upload/" . $_FILES["file"]["name"])) {
		echo $_FILES["file"]["name"] . " already exists. ";
	} else {
		move_uploaded_file($_FILES["file"]["tmp_name"], "upload/" . $_FILES["file"]["name"]);
		echo "Stored in: " . "upload/" . $_FILES["file"]["name"];
	}
}
} else {
echo "Invalid file";
}
?>

[jitesh]

<?php

echo "<pre>";
print_r($_FILES['file']);  // Print this and post the o/p here

if (($_FILES["file"]["type"] == "image/gif")
|| ($_FILES["file"]["type"] == "image/pjpeg")
&& ($_FILES["file"]["size"] < 2000000))
  {
  if ($_FILES["file"]["error"] > 0)
    {
..........
..........
.........
?>

[lewis987]

infact, i forgot opera store cache, i needed to empty it o load up the new page, it works now!

 

thanks a tonne!

[JakeTheSnake3.0]

I uploaded a small jpeg and it worked....

 

Upload: throw_away_religion.jpg
Type: image/jpeg
Size: 3.8388671875 Kb
Temp file: C:\xampp2\tmp\php52.tmp
Stored in: upload/throw_away_religion.jpg

 

Try a gif next...see if that works...

[igor berger]

Glad to see that you got it to work.

 

But I would set CHMOD to 766 it should work also.

 

With CHMOD 777 public can execute a program. So if it works with 766 do it, but if you need 777

then you have no choice.

But 777 is secyrety risk.