[SOLVED] simple 'while' problem

[chocopi]

I want to get a numerical vaule from my database and change it to a string

 

This is code i came up with, but its not working:

 

while($row = mysql_fetch_array($class))
	 {
	if ( $row['class'] == 1){
	$class = 'A';
	} else
	if ( $row['class'] == 2){
	$class = 'B';
	} else
	if ( $row['class'] == 3){
	$class = 'C';
	}
}
print ("You chose $class \n");

 

Any help would be greatly appreciated,

 

~ Chocopi

[quickstopman]

did you previously set $class as a variable?

[pocobueno1388]

Since you are using a while loop I am assuming you are trying to print "You chose $class" for each value from the DB? Why do you have your print outside of the while loop? Change your code to this:

 

<?php

while($row = mysql_fetch_array($class))
	 {
	if ( $row['class'] == 1){
	$class = 'A';
	} else
	if ( $row['class'] == 2){
	$class = 'B';
	} else
	if ( $row['class'] == 3){
	$class = 'C';
	}

             print "You chose". $class ."<br>";
}
?>

 

[kenrbnsn]

You're clobbering the variable $class, which is the pointer to the mysql query result, use a different variable.

 

This can be written much more efficiently by using an array:

<?php
$classes = array('','A','B','C');
while($row = mysql_fetch_assoc($class))
	 $cls = $classes[$row['class']];
echo "You chose $cls<br>\n";
?>

 

Ken

 

[chocopi]

Thanks for your help but that is still only showing 'You chose '

 

@quickstopman: Yes $class had already been set as that is the column name

[chocopi]

ok i found the problem and fixed. The mistake was sooooo n00bish i shall not tell you, but thanks for your help everyone.

 

Cheers,

 

~ Chocopi

[kenrbnsn]

Please post the solution, so that if some one else has the same problem, it will save them the time.

 

Ken

[chocopi]

it was not a problem with the code though, it was because i missed out:

 

<?php
$class = mysql_query("SELECT class FROM users WHERE username='$username'");
?>

 

so obviously no result could be posted because it was not being told where too look