Beginner Help Please (includes)

[chinrest]

"Cut-n-paste" programmer here--go easy on me.

 

I've used this code before, but it does not work on my current host (Dreamhost):

 

<?php

$invalidChars=array("/",".","\\","\"",";");

$page=str_replace($invalidChars,"",$page);

include ("pages/".$page.".html");

?>

 

When I call index.php?page=home, I get this is the error message:

 

Warning: include(.html) [function.include]: failed to open stream: No such file or directory in /home/user/domain/dev/index.php on line 44

 

Warning: include() [function.include]: Failed opening '.html' for inclusion (include_path='.:/usr/local/php5/lib/php') in /home/user/domain/dev/index.php on line 44

 

 

If I replace the $page variable with an actual file, and call index.php in the browser, it works fine:

 

<?php

$invalidChars=array("/",".","\\","\"",";");

$page=str_replace($invalidChars,"",$page);

include ("pages/home.html");

?>

 

Any help?

[taith]

what do you get when you echo $page...?

[Garath531]

Where is $page defined?

[kenrbnsn]

You have assumed that register_globals are enabled. While this used to be true many years ago, you can not and should not assume it anymore. Change your code to explicitly reference the appropriale superglobal array, in your case "$_GET".

 

<?php
$invalidChars=array("/",".","\\","\"",";");
$page=str_replace($invalidChars,"",$_GET['page']);
include ("pages/".$page.".html");
?>

 

Ken

[chinrest]

Thanks Ken. I really appreciate your help--Garath and Taith too, for your timely responses.