problem with my mysql query. Not setting data correctly

[Dragen]

okay what's wrong with this query?

$sqladdlead = "UPDATE staff SET firstname = '".$leader['0']."' && surname = '".$leader['1']."' WHERE firstname = '" . $rowlead['firstname'] . "' && surname = '" . $rowlead['surname'] . "' && position = 'leader'";

Every time I run it the data isn't sent properly. It seems to set the firstname as 0 and doesn't change the surname at all..

I've tried echoing the statement to see what's wrong and it looks fine..

echo "UPDATE staff SET firstname = '".$leader['0']."' && surname = '".$leader['1']."' WHERE firstname = '" . $rowlead['firstname'] . "' && surname = '" . $rowlead['surname'] . "' && position = 'leader'";

and that outputs something like:

UPDATE staff SET firstname = 'Lindy' && surname = 'Bawtree' WHERE firstname = '0' && surname = 'Bawtree' && position = 'leader'

Which seems fine (obviously the "WHERE firstname ='0'" is because I've tried editing the database and it's set to 0 at the moment, because of this query..)

 

If someone can point out my problem I'd be thankfull. It's probably just a stupid mistake.

Thanks

[trq]

You are incorrectly using &&, also, non numeric array indexes should not have there values surrounded by quotes. Try....

 

$sqladdlead = "UPDATE staff SET firstname = '".$leader[0]."', surname = '".$leader[1]."' WHERE firstname = '" . $rowlead['firstname'] . "' && surname = '" . $rowlead['surname'] . "' && position = 'leader'";

[Dragen]

haha, thanks. I knew I was being stupid..

I haven't used the update much and forgot to use ',' instead of '&&'.

Thanks!

[Dragen]

okay that query was sorted but now I'm having trouble with another UPDATE query..

$sql = "UPDATE staff SET mon = '" . $sday['mon'] . "', tues = '" . $sday['tues'] . "', weds = '" . $sday['weds'] . "', thurs = '" . $sday['thurs'] . "', fri = '" . $sday['fri'] . "', desc = '" . $desc . "' WHERE firstname = '" . $name['0'] . "' && surname = '" . $name['1'] . "'";

 

I get the message:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'desc = '' WHERE firstname = 'Susie' && surname = 'Campbell'' at line 1

 

So I guess it's the WHERE section that's wrong, but I don't see a problem with it.

Any help?

[jitesh]

$sql = "UPDATE staff SET mon = '" . $sday['mon'] . "', tues = '" . $sday['tues'] . "', weds = '" . $sday['weds'] . "', thurs = '" . $sday['thurs'] . "', fri = '" . $sday['fri'] . "', desc = '" . $desc . "' WHERE firstname = '" . $name['0'] . "' AND surname = '" . $name['1'] . "'";

 

[Dragen]

nope. You can use both '&&' and 'AND' for a mysql query.

[trq]

As I said earlier. Non numeric array keys should not be surrounded in quotes.

 

$name['0']

 

needs to be....

 

$name[0]

 

This makes perfect sense. Your code is looking for the string '0', accessing an array value with a string looks to php as though youve an associative array where in reality you dont.

[Dragen]

thanks thorpe, but that doesn't change anything. still the same error.

[trq]

Echo the query and show us the output.

[Dragen]

it seems to echo fine:

UPDATE staff SET mon = '1', tues = '1', weds = '1', thurs = '1', fri = '1', desc = '' WHERE firstname = 'Susie' && surname = 'Campbell'

I don't see a problem with that..

[trq]

Are you sure desc can handle an empty string? Other than that, I don't see any issue.

[Dragen]

It should be able to it's just a varchar, but I've also tried it with desc as a value as well but it still doesn't work.

[Dragen]

figured it out!

quite silly really.. it's the desk name for my table row. I can't use desk as it's a reserved name, so I've just put it as `desc`, which works absolutely fine...

 

Thanks