Qusetion?

[Trium918]

Which is the best way to do this?

 

Like this

<?php
$sql = mysql_query("SELECT * FROM table")or die(mysql_error());

$num_results = mysql_num_rows($sql); 

for ($i = 0; $i < $num_results; $i++) {

$row = mysql_fetch_array($sql);
//result

}
?>

or

<?php
$sql = "SELECT * FROM table";

$res =mysql_query($sql) or die (mysql_error());
$num_results = mysql_num_rows($res); 

for ($i = 0; $i < $num_results; $i++) {

$row = mysql_fetch_array($res);
//result

}
?>

[dustinnoe]

I like the second option because most of my queries are rather long so the code just looks cleaner.  In the case of a short UPDATE or DELETE query I will go with something similar to the first option.

[rameshfaj]

From optimization point of view the former is better!

[trq]

Neither is very good.

 

<?php

  // connect

  $sql = "SELECT foo FROM tbl";
  if ($result = mysql_query($sql)) {
    if (mysql_num_rows($result)) {
      while ($row = mysql_fetch_assoc($result)) {
        echo $row['foo']."<br />";
      }
    } else {
      echo "No results found";
    }
  } else {
    echo "Query failed<br />$sql<br />" . mysql_error();
  }

?>

[gabeg]

Neither is very good.

 

<?php

  // connect

  $sql = "SELECT foo FROM tbl";
  if ($result = mysql_query($sql)) {
    if (mysql_num_rows($result)) {
      while ($row = mysql_fetch_assoc($result)) {
        echo $row['foo']."<br />";
      }
    } else {
      echo "No results found";
    }
  } else {
    echo "Query failed<br />$sql<br />" . mysql_error();
  }

?>

 

This is gets my vote. Similar as to what I was going to suggest

[dustinnoe]

I thought we were just voting on setting the query into it's own variable as opposed to setting the result of mysql_query() in $sql.  I do like thorpe's submission as an overall solution though.

[Barand]

The expensive elements are time spent developing/debugging and maintaining code, not shaving a couple of millisecs off the execution time.

 

So I go with the increased readability and debugging from putting it in a separate variable. My 0.02.

[dustinnoe]

The expensive elements are time spent developing/debugging and maintaining code, not shaving a couple of millisecs off the execution time.

 

So I go with the increased readability and debugging from putting it in a separate variable. My 0.02.

 

What if strlen($sql) < 25ish? would you go for saving a few milliseconds then?

[Barand]

If the sql contains variables, yes, for debugging.

 

Although, I admit I do

 

$res = mysql_query("SELECT COUNT(*) FROM table");

 

but then there isn't much to debug.