[SOLVED] Mysql Insert Query..q

[clanstyles]

I can't figure out whats wrong witht his query. It looks fine to me but somebody else please...have a look

 

mysql_query("INSERT INTO `serverInfo` ( `id` , `serverid` , `size` , `filename` , `timestamp` ) VALUES('null', '1', '".$size."', '".$dir."', '".$date."'") or die(mysql_error());

 

Anything stupidly wrong here? the id,serverid, size, filename,timestamp thsoe are all right.

 

Error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

[pocobueno1388]

Try it without concating the variables.

 

mysql_query("INSERT INTO `serverInfo` ( `id` , `serverid` , `size` , `filename` , `timestamp` ) VALUES('null', '1', '$size', '$dir', '$date')") or die(mysql_error());

 

Try using mysql_real_escape_string() on all of those variables before insert as well.

[clanstyles]

of course  i did that lol

 

but I will try that function

[Wildbug]

You're missing the closing parenthesis for the VALUES(... portion.

 

 

 

EDIT: I was wrong the first time.

[Wildbug]

It's useful to assemble the query in a variable before passing it to mysql_query().  That way you can print it out along with the error in a die() function and see things that will be more obvious than in the often cluttered, complex string concatenations we use to build queries.