[SOLVED] Help please

[jck]

im trying to create a script for my jokes site that lets u see what others have voted for any joke the strucure of the table is simple itemid,rating and username this is the sample code i wrote for a joke of item id 54 but when i run it i get blank page please help me

<?
require_once("conn.php");
require_once("templates/MainHeader.php");

$q1 = "select * from dd_rating where ItemID = '54' ";
$r1 = mysql_query($q1) or die(mysql_error());
$numvote=mysql_numrows($r1)
echo "<b><center>See what Rating others gave for this joke </center></b><br><br>";

$i=0;
while($i<$numvote){

$name=mysql_result($r1,$i,"username");
$rate=mysql_result($r1,$i,"Rating");

echo"$name." had given a rating of".$rate." to this joke<br>";

$i++
}
require_once("templates/MainFooter.php");
?>

 

Please tell me whats wrong with it

[cmgmyr]

try: echo $name." had given a rating of ".$rate." to this joke<br>";

[jck]

even the see whatr others have rated line didnt come

[jck]

try: echo $name." had given a rating of ".$rate." to this joke<br>";

 

Still blank

[cmgmyr]

how about:

<?php
require_once("conn.php");
require_once("templates/MainHeader.php");

$q1 = "select * from dd_rating where ItemID = '54' ";
$r1 = mysql_query($q1) or die(mysql_error());
$numvote = mysql_num_rows($r1); //<~Semi colon missing
echo "<b><center>See what Rating others gave for this joke </center></b><br><br>";

$i=0;
while($i<$numvote){
$name=mysql_result($r1,$i,"username");
$rate=mysql_result($r1,$i,"Rating");

echo $name." had given a rating of ".$rate. " to this joke<br>";

$i++
}
require_once("templates/MainFooter.php");

?>

[jck]

still blank ??? ???

[JayBachatero]

Try this.

 

<?php
require_once("conn.php");
require_once("templates/MainHeader.php");

$request = mysql_query("
SELECT rt.username, rt.Rating
FROM dd_rating AS rt
WHERE ItemID = 54") or die(mysql_error());

echo '<b><center>See what Rating others gave for this joke </center></b><br><br>';

while ($row = mysql_fetch_assoc($request))
{
$name = $row['username'];
$rate = $row['Rating'];

echo '
' . $name . ' had given a rating of ' . $rate . ' to this joke.<br />';
}
mysql_free_result($request);

require_once("templates/MainFooter.php");
?>

[jck]

Thank u very much it worked but i have 2 questions the first question is whhat was wrong in mine beside the missing semicolon?

[jck]

and the secound one how to implement it on

*/view.php?ItemID=54

[JayBachatero]

You are missing another ; after the counter.  I suggest that you enable error reporting while in development.  Add

error_reporting(E_ALL);

to your main file.  In this case conn.php.

[cmgmyr]

...damn missed that

 

anyways use something like:

$id = $_GET['id'];
$request = mysql_query("
SELECT rt.username, rt.Rating
FROM dd_rating AS rt
WHERE ItemID = $id") or die(mysql_error());

[JayBachatero]

Try

<?php
require_once("conn.php");
require_once("templates/MainHeader.php");

if (isset($_GET['ItemID']) && is_numeric($_GET['ItemID']))
{
$request = mysql_query("
	SELECT rt.username, rt.Rating
	FROM dd_rating AS rt
	WHERE ItemID = $_GET[itemID]") or die(mysql_error());

echo '<b><center>See what Rating others gave for this joke </center></b><br><br>';

if (mysql_num_rows($request) > 0)
{
	while ($row = mysql_fetch_assoc($request))
	{
		$name = $row['username'];
		$rate = $row['Rating'];

		echo '
		' . $name . ' had given a rating of ' . $rate . ' to this joke.<br />';
	}
}
else
	echo 'No ratings for this joke.';
}
else
echo 'The ItemID is not valid.';

require_once("templates/MainFooter.php");
?>

[jck]

im very new to this could u please explain me what to what was that

rt.username thing and obviously ur code will be more efficient than mine can u explain how??

 

and im very lucky that a devoloper of smf helped me

[JayBachatero]

Ok lets break it down.

 

This part checks first to see if "ItemID" is set in the URL.  If it's set then it checks to see if it's numeric.  The point of that is so that you can have some sanity checks and make sure that a number was entered.

if (isset($_GET['ItemID']) && is_numeric($_GET['ItemID']))

 

In dd_rating AS rt the rt part is the alias for that table.  You usually use table alias when you are joining more than one tables.  You don't want to keep typing xxx.yyy for each column that you want.

SELECT m.id_member, m.name, m.age, rt.ratings
FROM members AS m
LEFT JOIN ratings AS tr ON (tr.id_member = m.id_member)

Imagine having to write members.x each time and so on.

 

Also it is good to select the columns that you will be using instead of doing a SELECT *.  Doing that will select all the columns in that table.

[jck]

thank u very much ive understood a little better now

[jck]

thanks to chris too