help!values dont display?

[asherinho]

wats up friends,I am xampp for learning php but recently i faced this problem where the values sent by the script are not display in the database but the rows is added with empty values and the script dont show any error message and the query is succesfull.check the codes

 

 

<?php
$db=mysql_connect("localhost","root");
if(!$db){echo "not connected";}
mysql_select_db("trials",$db);
$query="INSERT INTO organizations VALUES('{$_POST['university']}','{$_POST['colledge']}','{$_POST['institute']}')";
$result=mysql_query($query);
if(!$result){echo "values were not sent".mysql_error();}
  else{echo "values where sent";}
?>

 

EDITED BY akitchin:  code-tag-ified.

[mpharo]

Well for one you spelled college wrong...

 

$_POST['colledge']

 

Also you do not need the {} in each of the post variables...

 

I also assume you are putting in a password in your mysql_connect(); function...

[akitchin]

Also you do not need the {} in each of the post variables...

 

wrong:  try running that string definition in PHP without the braces, you'll get a parse error.

 

there's a chance you're using the GET method rather than the POST method.  try echoing your variables before putting them in the query, as this will tell you if the problem is with your query or if it is with your form.  i'm going to say it's with the form, as the !$result condition is proving false.

[mpharo]

wrong:  try running that string definition in PHP without the braces, you'll get a parse error.

 

my mistake I forgot about the single quotes in the index...

 

[wildteen88]

You should check whether the variables have values first before using them and never use raw _POST/_GET data in a query.

<?php

// check that the form has been submitted
// normally you'd do this by checking whether the variable
// _POST['submit'] exists which will correspond to the forms submit button
// for this to work make sure you ngive your submit button the name 'submit', eg:
// <input type="submit" name="submit" value="Submit" />
if(isset($_POST['submit']))
{
    $errors = null;

    // check that variables exist first before using the
    if(!isset($_POST['university']) || empty($_POST['university']))
    {
        // if the variable doesn't exist or the variable holds an empty value
        // set an error message
        $error[] = 'Univeristy not supplied';
    }

    if(!isset($_POST['colledge']) || empty($_POST['colledge']))
    {
        $error[] = 'Colledge not supplied';
    }

    if(!isset($_POST['institute']) && empty($_POST['institute']))
    {
        $error[] = 'Institute not supplied';
    }

    // check that the errors variable is not any array
    if(!is_array($errors))
    {
        // error variable is not an array


        // connect to mysql and select database
        $db = mysql_connect('localhost', 'root') or die('not connected');
        mysql_select_db('trials', $db);

        // process submitted data

        // before you use raw _POST data in an query it is recommended to run data strings
        // from the user through mysql_real_escape_string function to pretect against SQL Injection attacks
        $uni = mysql_real_escape_string($_POST['university']);
        $col = mysql_real_escape_string($_POST['colledge']);
        $inst = mysql_real_escape_string($_POST['institute']);

        // setup the query
        $query = "INSERT INTO organizations VALUES('$uni','$col}','$inst')";

        // run the query
        $result = mysql_query($query);

        // check for result
        if($result)
        {
            echo 'Data inserted into database';
        }
        else
        {
            echo 'Error: Unable to add data into database<br />' . mysql_error();
        }
    }
    // if the error variabble is not an array we'll display the errors:
    else
    {
        echo "Please correct the following errors:<br />\n!";
        echo "<ul>\n<li>\n";
        echo implode("</li>\n<li>", $errors);
        echo "</li>\n</ul>\n\n";
    }
}
?>