$_GET from a URL?

[LemonInflux]

You probably know by now, I'm setting up an image uploader for a project, and want to add user interfaces. Well, everything's ok now, apart from delete. With help, I've come upon this code:

 

<?php
$files = array();
$dir=opendir($f_user);
while(($file = readdir($dir)) !== false)  
{  
if($file !== '.' && $file !== '..' && !is_dir($file))  
{  
	$files[] = $file;  
}  
}  
closedir($dir);
natcasesort($files);
echo "<ul>\n";
for($i=0; $i<count($files); $i++)  
{
if($files[$i] != "index.php")
echo "<li><a href=\"$dir/".$files[$i]."\">".$files[$i]."</a> - <a href=\"delete.php?del=$files[$i]\">Delete</a></li>\n";
}
echo "</ul>\n";
?>      

 

This code lists the directory contents and adds a 'delete' option next to the file. Upon pressing delete, it will send you to

http://reflexprojects.net/rs/upload/delete.php?del=yourfile.whatever

 

In delete.php, I have

 

<?php

$file = $_GET['del'];
$dir = "$f_user/$file"
if(unlink($dir)) {
echo "The file was deleted successfully.";
}
else {
echo "There was an error trying to delete the file.";
}

?>

 

Basically, this gets the file and tries to delete it. However, on this screen, I get nothing, just a blank white page. Not even the error echo works. So, here's my question: What's wrong with the second script?

 

If you would like to see what happens, log in at http://reflexprojects.net/rs/upload/secure_page.php?, with username and password as 'test'. Upload a picture, then try to delete it. Thanks in advance, Tom.

[phpSensei]

why is this empty?

 

$files[] = $file;

[LemonInflux]

Should it have anything in?

[lemmin]

I would think it is supposed to be empty.

 

I think the unlink function might be causing some kind of problem. What if you do "echo $dir" right before the unlink line? See if something gets displayed, if not, comment out that entire if statement and see what it prints out for the $dir, it might be something weird.

[LemonInflux]

It doesn't echo anything, still blank page :\

[Fadion]

Are u sure u have a directory like: $dir = "$f_user/$file"? Normally if smth goes wrong an error should be printed, but maybe u have error_reporting off. If u have access to php.ini or a custom one try chaning error_reporting = e_all to see if u get any error.

[LemonInflux]

Morning bump. Yes, I'm sure I do. That's where the images are stored. I'll check errors.

[LemonInflux]

No errors even show. It's just completely blank.

[LemonInflux]

I'm fairly sure it's the GET thing. There isn't much else that could be causing it..

[darkfreaks]

did you try replacing $_GET with $_REQUEST ?

[LemonInflux]

No, but I just tried it, and no luck :\

[darkfreaks]

ty doing a query and selecting it that way?

[LemonInflux]

erm...Was that 'thank' 'you doing a query and selecting it that way?' or 'thank you' 'doing a query and selecting it that way? And read the code, I'm not sure there's another way of displaying the directory contents in a list in another way.

[darkfreaks]

oops sorry my keyboard is being weird anyway i was trying to say do a mysql_query to select the delete field and grab it that way.

[LemonInflux]

There's no MySQL involved. This was a test to see if I could do it without MySQL. I'm sure I can, if I just work this bit out. Everything else has been fine..

[darkfreaks]

<?php (!isset($_GET['del'])){ 
echo "Could not Delete the file!";
} else { 
$file = $_GET['del']; 
} 
?>

[LemonInflux]

Yet again, the all to friendly 'blank screen' shows.

[darkfreaks]

<?php if (!isset($_GET['del'])){ 
echo "Could not Delete the file!";
} else { 
$file = $_GET['del']; 
} 
?>

[LemonInflux]

Blank..

[darkfreaks]

not sure if thi will help but i got this from php.net when i looked up opendir delete

 

<?php


recursive_delete($dir);

function recursive_delete( $dir )
{
        if (is_dir($dir)) {
           if ($dh = opendir($dir)) {
               while (($file = readdir($dh)) !== false ) {
                        if( $file != "." && $file != ".." )
                        {
                                if( is_dir( $dir . $file ) )
                                {
                                        echo "Entering Directory: $dir$file<br/>";
                                        recursive_delete( $dir . $file . "/" );
                                        echo "Removing Directory: $dir$file<br/><br/>";
                                        rmdir( $dir . $file );
                                }
                                else
                                {
                                        echo "Deleting file: $dir$file<br/>";
                                        unlink( $dir . $file );
                                }
                        }
               }
               closedir($dh);
           }
        }
}

?>

[LemonInflux]

Uuuh...That just emptied the folder.

[LemonInflux]

Wait, no it didn't, it just didn't list anything.

[darkfreaks]

weird so it didnt work at all?

[LemonInflux]

nope. Just, blank.

[darkfreaks]

oops try adding

 

$dir = "/path/to/base/dir";

 

 

appearantly i left that line out so it wouldnt read the directory path and wouldnt do anything.