[SOLVED] Function help

[Aureole]

Hey, I've just started playing around with Functions but I can't get this to work I'm just wondering if anyone knows why. It looks fine to me, thanks a lot.

 

<?php

session_start();

include('functions.php');

dbConnect();

echo('Hello '.$_SESSION['mem_dname'].'. You have ');
checkPms($_SESSION['mem_id']);
echo(' New Messages.');
?>

 

My functions.php file:

 

<?php
function dbConnect()
{
    $dbhost = 'localhost';
    $dbuser  = '********';
    $dbpass  = '********';
    $dbname = '********';
    $conn = mysql_connect($dbhost, $dbuser, $dbpass) or die(mysql_error());
    mysql_select_db($dbname) or die(mysql_error());
}

function checkPms($who)
{
    $query = "SELECT * FROM `messages` WHERE pmread='0' AND to_id='{$who}'";
    $newpms = mysql_num_rows($query);
    return $newpms;
}
?>

 

Just so you know the Database is connected and I have populated the Database and it's just showing..."You have New Messages".

 

EDIT: Yes I did have session_start(); in my script I just forgot to put it on here.

[ToonMariner]

yep its variable scope...

 

this is not reall the best use of a function

your databse connection is something that should (in 99%) of cases only do once per page and as such does NOT need to be in a function.

 

read up on variable scope - we could tell you but you won't learn it anywhere near as well...

 

http://uk2.php.net/manual/en/language.variables.scope.php

[Aureole]

But the thing is I use that function dbConnect(); on every page and it does connect as I have other things that query the Database etc. this is the only one that won't work...or does the checkPms(); need to not be a Function too...?

 

I read the variable scope thing but and tried making $newpms global etc. and that didn't work...so I don't know...

[ToonMariner]

the go and replace dbConnect(); with something like

 

require_once('path/to/dbconnect/file.php');

 

and put all the db connection stuff in that one file. (No functions mind!)

[Aureole]

Ok but what I'm trying to say is that dbConnect(); works fine, regardless of if I shouldn't have it in a Function. The thing that won't work is checkPms(); although I got it to work now...but thanks anyway. I'll go do that. 

[ToonMariner]

since you have declared the connection INSIDE A FUNCTION the resource WILL ONLY BE AVAILABLE INSIDE THAT FUNCTION.

[Aureole]

Ok I think I grasp the idea of it now, thanks a lot for your help.