[SOLVED] Help with Script

[darkfreaks]

ok i need a way to return the right output but it only returns true until you get to normal weight, everything after that returns false so if your over weight or obese it just says your normal weight and no one so far can rectify the problem.

 

<?php

} elseif ($total<18.50){	
print"Your Body Mass Index is"; printf ('%01.2f',$total); echo "%"; print "<b>You are Currently Underweight This is not healthy</b>";}
else if ($total>18.50){print "Your Body Mass Index is"; printf ('%01.2f',$total);
print "%"; print "<b>You are Normal Weight, give yourself a pat on the back!</b>";}

elseif ($total<25){print "Your Body Mass Index is"; printf ('%01.2f',$total);
print "%"; print "<b>You are Normal Weight, give yourself a pat on the back!</b>";}
else if ($total>25){echo "Your Body Mass Index is"; printf ('%01.2f',$total);
print "%"; print "<b>You are Over Weight, Get to Exercizing on a Daily Basis!</b>";}

elseif ($total<30){print "Your Body Mass Index is"; printf ('%01.2f',$total);
print "%"; echo "<b>You are Over Weight, Get to Exercizing on a Daily Basis!</b>";}

elseif ($total>30){echo "Your Body Mass Index is"; printf ('%01.2f',$total);
print "%"; print "<b>You are Over Weight, Get to Exercizing on a Daily Basis! Consult a Doctor ASAP!</b>";}


?>

[darkfreaks]

any ideas? ???

[LemonInflux]

Hm. So the first one works, and no other ones do?

 

Also, the first }; is this only part of the code?

[darkfreaks]

well before the html form i have an if ($error) { ?> statement

[LemonInflux]

Hmm...I can't see a difference between each section...It's a problem with the if's, I'm fairly sure. But I can't find it.

[BlueSkyIS]

yow, mang, fix up your code so we can read it.   

 

if ($total<18.50){

   print"Your Body Mass Index is";

   printf ('%01.2f',$total);

   echo "%";

   print "<b>You are Currently Underweight This is not healthy</b>";

} else if ($total>18.50) { // THIS IS ALWAYS TRUE unless $total == 18.50.

 

One fix is to start at the lowest number and use < upward:

 

if ($total <18.50) { 
     // do something
} else if ($total <= 25) {
     // do something
} else if ($total <= 30) {
    // do something
} else { // Total is > 30
  // do something
}

[darkfreaks]

the problemat lies with the following statements as underweight and normal weight return true

 

<?php
elseif ($total<30){print "Your Body Mass Index is"; 
printf ('%01.2f',$total);
print "%"; print
"<b>You are Over Weight, Get to Exercizing on a Daily Basis!</b>";}

elseif ($total>30){print
"Your Body Mass Index is"; 
printf ('%01.2f',$total);
print "%"; print "<b>You are Over Weight, 
Get to Exercizing on a Daily Basis! Consult a Doctor. </b>"; ?>

[The Little Guy]

change them all to if, not else if, and see if that does it.

[darkfreaks]

i tried that and the problem with that is it echos on submit every single statement

[BlueSkyIS]

ah come on guys/gals. follow the logic

 

if ($total < 18.50) { // The total is LESS THAN 18.5

   // But it's not so...

 

} else if ($total > 18.50) {

   // It's not less than 18.5, right? Therefore it is either equal to or > 18.50. Assuming it's not = 18.5, then it is greater than 18.5, therefore this IF is true.

 

No?? The exact same problem is encountered if $total is > 30.

 

You need to either nest your IF's (lenghty) or use an incremental if as I stated before:

 

if ($total <18.50) {

    // do something

} else if ($total <= 25) {

    // do something

} else if ($total <= 30) {

    // do something

} else { // Total is > 30

  // do something

}

[BlueSkyIS]

here, to replace your first code:

 

<?
} elseif ($total<18.50) {	
print"Your Body Mass Index is";
printf ('%01.2f',$total);
echo "%";
print "<b>You are Currently Underweight This is not healthy</b>";
} else if ($total < 25) {
print "Your Body Mass Index is";
printf ('%01.2f',$total);
print "%";
print "<b>You are Normal Weight, give yourself a pat on the back!</b>";
} elseif ($total< 30) {
print "Your Body Mass Index is"; 
printf ('%01.2f',$total);
print "%";
print "<b>You are Over Weight, Get to Exercizing on a Daily Basis!</b>";
} else {
echo "Your Body Mass Index is";
printf ('%01.2f',$total);
print "%";
print "<b>You are Over Weight, Get to Exercizing on a Daily Basis! Consult a Doctor ASAP!</b>";
}
?>

[darkfreaks]

now i get

 

Warning: Division by zero in /home/lilysgra/public_html/BMIcalc.php on line 10

 

 

 

[darkfreaks]

fixed! i figured out that the max allowed else if's is 3 by dafault so i did 3 of those and an else. works now perfect thanks for the help!