[SOLVED] login script using sessions, wont work!

[brophi]

I know that there is a topic about this but it didnt help me very much. I am fairly new to php and i have no idea why my code is displaing these errors, any help would be greatly apretiated!!!!

 

the code:

<link href="style.css" rel="stylesheet" type="text/css" />
<?php 
include("connect.php");
$sql = mysql_query("SELECT * FROM users WHERE username='".addslashes($_POST['username'])."'") or die("username was in correct. MySQL said".mysql_error());
$result = mysql_fetch_array($sql);
if($result['password'] == sha1($_POST['password'])){
session_start();
header("Cache-control: private");
$_SESSION["sessioname"] = $_POST['username'];
header("location: protected.php");
}else{
echo "Incorrect login details please try again.";
}
?>

 

and the error:

Warning: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent (output started at C:\xampp\htdocs\site\login.php:2) in C:\xampp\htdocs\site\login.php on line 7

 

Warning: Cannot modify header information - headers already sent by (output started at C:\xampp\htdocs\site\login.php:2) in C:\xampp\htdocs\site\login.php on line 8

 

Warning: Cannot modify header information - headers already sent by (output started at C:\xampp\htdocs\site\login.php:2) in C:\xampp\htdocs\site\login.php on line 10

 

Thank you and im im sorry again...

[darkfreaks]

put ob_start(); before session start

[trq]

session_start() cannot be called after any[/i] output has been sent to your browser. This....

 

<link href="style.css" rel="stylesheet" type="text/css" />

 

is output.

[LemonInflux]

I was just going to say, put it at the very top. <?php session_start(); ?> then put your css

[trq]

put ob_start(); before session start

 

That is a hack. You need (or should) move your logic so as session_start() need not be called after output.

[LemonInflux]

Try this:

 

<?php 
session_start();
echo '<link href="style.css" rel="stylesheet" type="text/css" />';
include("connect.php");
$sql = mysql_query("SELECT * FROM users WHERE username='".addslashes($_POST['username'])."'") or die("username was in correct. MySQL said".mysql_error());
$result = mysql_fetch_array($sql);
if($result['password'] == sha1($_POST['password'])){
header("Cache-control: private");
$_SESSION["sessioname"] = $_POST['username'];
header("location: protected.php");
}else{
echo "Incorrect login details please try again.";
}
?>

[brophi]

Thanks for the quick reply! but sorry, its still not working... I did manage to get rid of some of the errors, tahnks to your help

 

here is my code NOW:

<?php session_start(); ?>
<link href="style.css" rel="stylesheet" type="text/css" />
<?php 
include("connect.php");
$sql = mysql_query("SELECT * FROM users WHERE username='".addslashes($_POST['username'])."'") or die("username was in correct. MySQL said".mysql_error());
$result = mysql_fetch_array($sql);
if($result['password'] == sha1($_POST['password'])){
header("Cache-control: private");
$_SESSION["sessioname"] = $_POST['username'];
header("location: protected.php");
}else{
echo "Incorrect login details please try again.";
}
?>

 

And here are the errors...

Warning: Cannot modify header information - headers already sent by (output started at C:\xampp\htdocs\site\login.php:3) in C:\xampp\htdocs\site\login.php on line 8

 

Warning: Cannot modify header information - headers already sent by (output started at C:\xampp\htdocs\site\login.php:3) in C:\xampp\htdocs\site\login.php on line 10

[rajivgonsalves]

Your code should be like this

 

<?php 
session_start();
include("connect.php");
$sql = mysql_query("SELECT * FROM users WHERE username='".addslashes($_POST['username'])."'") or die("username was in correct. MySQL said".mysql_error());
$result = mysql_fetch_array($sql);
if($result['password'] == sha1($_POST['password'])){
header("Cache-control: private");
$_SESSION["sessioname"] = $_POST['username'];
header("location: protected.php");
}else{
echo '<link href="style.css" rel="stylesheet" type="text/css" />'
echo "Incorrect login details please try again.";
}
?>

[brophi]

GRRR! Its still not working! i used the code above:

<?php 
session_start();
include("connect.php");
$sql = mysql_query("SELECT * FROM users WHERE username='".addslashes($_POST['username'])."'") or die("username was in correct. MySQL said".mysql_error());
$result = mysql_fetch_array($sql);
if($result['password'] == sha1($_POST['password'])){
header("Cache-control: private");
$_SESSION["sessioname"] = $_POST['username'];
header("location: protected.php");
}else{
echo '<link href="style.css" rel="stylesheet" type="text/css" />'
echo "Incorrect login details please try again.";
}
?>

 

but that didnt work:

Parse error: syntax error, unexpected T_ECHO, expecting ',' or ';' in C:\xampp\htdocs\site\login.php on line 12

 

I fixed that error:

<?php 
session_start();
include("connect.php");
$sql = mysql_query("SELECT * FROM users WHERE username='".addslashes($_POST['username'])."'") or die("username was in correct. MySQL said".mysql_error());
$result = mysql_fetch_array($sql);
if($result['password'] == sha1($_POST['password'])){
header("Cache-control: private");
$_SESSION["sessioname"] = $_POST['username'];
header("location: protected.php");
}else{
echo "Incorrect login details please try again.";
echo '<link href="style.css" rel="stylesheet" type="text/css" />';
}
?>

 

BUT THEN I GET THIS ERROR AGAIN!!

Warning: Cannot modify header information - headers already sent by (output started at C:\xampp\htdocs\site\connect.php:2) in C:\xampp\htdocs\site\login.php on line 7

 

Warning: Cannot modify header information - headers already sent by (output started at C:\xampp\htdocs\site\connect.php:2) in C:\xampp\htdocs\site\login.php on line 9

 

PLEASE HELP! this is very frustrating!

[brophi]

Oh wait! thats for a different file! silly me, i will try yo fix that one! i feel so stupid

 

EDIT!

YAY I FIXED IT!

thanks for all your help, its really appretiated

 

 

(no sarcasm intended)