Anyone debug this?

[wooowooo]

hi all, dont know why this isnt working

 

Atm got an error on line 17 T_string expeting (

 

<?php

// connect to db


$num_fields= mysql_num_fields($query_result );
if ($num_fields) { //build the order by row
echo "<tr>" ; 
for ($i = 0; $i < $num_fields; $i++) {
$colname = mysql_field_name($query_result , $i) ;
//build a default header for both ascending and descending link
$orderlink = ("<a href=\"" . $_SERVER["PHP_SELF"] . "?columnname=" . $colname . "&sort=desc\" title=\"Sort the records in descending order\">Sort descending</a>") ;
$orderlink .= "  " ;
$orderlink .= ("<a href=\"" . $_SERVER["PHP_SELF"] . "?columnname=" . $colname . "&sort=asc\" title=\"Sort the records in ascending order\">Sort ascending</a>") ; 

if $_GET['columnname']== $colname {
if ($order=="asc") {
$orderlink = ("<a href=\"" . $_SERVER["PHP_SELF"] . "?columnname=" . $colname ." &sort=desc\" title=\"Sort the records in descending order\">Sort descending</a>") ; // default replaced by single link
} else {
$orderlink = ("<a href=\"" . $_SERVER["PHP_SELF"] . "?columnname=" . $colname . "&sort=asc\" title=\"Sort the records in ascending order\">Sort ascending</a>") ; 
}
}
echo ("<td>" . $orderlink . "</td>" ; // place each link-couplein a new cell
}
echo "</tr>" ;
} else {
echo "Empty recordset" ;
}
//and then here comes your code to display the records from the recordset.
while ($row = @mysql_fetch_array ($query_result)) {

echo " <tr align=\"center\" bgcolor=\"$row[colourcode]\"> 
<td align=\"left\"><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\" color=\"#006699\">&nbsp$row[CustomerID]</font></td>
<td align=\"left\"><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\" color=\"#006699\">&nbsp$row[Name]</font></td>
<td align=\"left\"><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\" color=\"#006699\">&nbsp$row[Address]</font></td>
<td align=\"left\"><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\" color=\"#006699\">&nbsp$row[Postcode]</font></td>
<td align=\"left\"><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\" color=\"#006699\">&nbsp$row[Telephone]</font></td>
<td align=\"left\"><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\" color=\"#006699\">&nbsp$row[Email]</font></td>
</tr>";

}

?>

[revraz]

Indent your code, it will be easier to find the missing bracket.

[revraz]

Where do you set $order?

 

Looks like you are missing $order = $_GET['order']; before

if ($order=="asc")

[wooowooo]

if ($order=="asc") {

 

 

[revraz]

Yeah, but if $order won't do no good if you don't have anything in the $order variable right?

[revraz]

Also change

 

if $_GET['columnname']== $colname {

 

to

 

if ($_GET['columnname']== $colname) {

[revraz]

And remove the ( from here

 

echo ("<td>" . $orderlink . "</td>" ; // place each link-couplein a new cell

 

echo "<td>" . $orderlink . "</td>" ; // place each link-couplein a new cell

[marcus]

<?php

// connect to db


$num_fields = mysql_num_fields($query_result);
if ($num_fields) { //build the order by row
    echo "<tr>";
    for ($i = 0; $i < $num_fields; $i++) {
        $colname = mysql_field_name($query_result, $i);
        //build a default header for both ascending and descending link
        $orderlink = ("<a href=\"" . $_SERVER["PHP_SELF"] . "?columnname=" . $colname .
            "&sort=desc\" title=\"Sort the records in descending order\">Sort descending</a>");
        $orderlink .= "  ";
        $orderlink .= ("<a href=\"" . $_SERVER["PHP_SELF"] . "?columnname=" . $colname .
            "&sort=asc\" title=\"Sort the records in ascending order\">Sort ascending</a>");

        if ($_GET['columnname'] == $colname) {
            if ($order == "asc") {
                $orderlink = ("<a href=\"" . $_SERVER["PHP_SELF"] . "?columnname=" . $colname .
                    " &sort=desc\" title=\"Sort the records in descending order\">Sort descending</a>"); // default replaced by single link
            } else {
                $orderlink = ("<a href=\"" . $_SERVER["PHP_SELF"] . "?columnname=" . $colname .
                    "&sort=asc\" title=\"Sort the records in ascending order\">Sort ascending</a>");
            }
        }
        echo "<td>" . $orderlink . "</td>"; // place each link-couplein a new cell
    }
    echo "</tr>";
} else {
    echo "Empty recordset";
}
//and then here comes your code to display the records from the recordset.
while ($row = @mysql_fetch_array($query_result)) {

    echo "<tr align=\"center\" bgcolor=\"$row[colourcode]\"> 
<td align=\"left\"><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\" color=\"#006699\">&nbsp$row[CustomerID]</font></td>
<td align=\"left\"><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\" color=\"#006699\">&nbsp$row[Name]</font></td>
<td align=\"left\"><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\" color=\"#006699\">&nbsp$row[Address]</font></td>
<td align=\"left\"><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\" color=\"#006699\">&nbsp$row[Postcode]</font></td>
<td align=\"left\"><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\" color=\"#006699\">&nbsp$row[Telephone]</font></td>
<td align=\"left\"><font size=\"2\" face=\"Verdana, Arial, Helvetica, sans-serif\" color=\"#006699\">&nbsp$row[Email]</font></td>
</tr>";
}

?>

 

neat too.

[wooowooo]

Warning: mysql_num_fields(): supplied argument is not a valid MySQL result resource in /home/.julia/bex/bex.st18.co.uk/wk8ex3.2.php on line 10

Empty recordset

 

Still not working

[marcus]

Your fault not ours.

 

$whateveryourqueryvariableiscalled = mysql_query("w/e") or die(mysql_error());

[trq]

You are the one responisble for debuging your own code. That error usually means your query is failing and you have failed to check it for success prior to trying to use its result.

 

Fix it.

[revraz]

You don't even have $query_result defined in your code.