[SOLVED] Alphnumeric Checking

[mike177]

Hi, I am having some trouble with my alphanumeric error checking on passwords with my login script.

I am using the following to check the password, its the last "else if" statment, I thought it would be helpful to include the whole proccess:

/*Password error checking*/
$field = "pass";
if(!$subpass){
	$form->setError($field, "* Password Not Entered");
}
else{
	$subpass = stripslashes($subpass);
	if(strlen($subpass) < {
		$form->setError($field, "* Password Must Contain Between 8-15 Characters");
	}
	else if(strlen($subpass) > 15){
		$form->setError($field, "* Password Must Containe Between 8-15 Characters");
	}
	else if(!ereg("([0-9A-Za-z])", ($subpass = trim($subpass)))){
		$form->setError($field, "* Password Must Be Alphanumeric");
	}
}

Note: I am also trimming the password, I've tried removing the trim but that had no effect. I'm not receiving any error messages, it just enteres the password in the database alphanumeric or not.

 

Any suggestions.

 

Thanks in advance for any help.

[phpSensei]

Where is the $subpass var?

[mike177]

Where is the $subpass var?

Its just the password from the user input form and its pasted from proccess but it has no other major operations so I didn't include it.

[inet411]

untested but try replacing:

 

else if(!ereg("([0-9A-Za-z])", ($subpass = trim($subpass)))){

 

with

               

else if(!ereg("([^0-9A-Za-z])", ($subpass = trim($subpass)))){

[revraz]

Use ctype instead of regex.

[roopurt18]

You could use ctype as revraz suggested, but the problem with your first attempt was the wrong regexp:

([0-9A-Za-z])

 

1) Minor note, but the parens aren't needed.

 

2) The problem, that regexp matches a single alphanumeric character.  Add a + to it if you want it to match one or more.

 

[0-9A-Za-z]+

 

(edit) While I'm at it, might as well write the regexp to eliminate all of your if statements:

/^[0-9A-Za-z]{8,15}$/

That matches all alphanumeric strings 8 to 15 characters in length with no beginning or trailing white space.

 

if(!preg_match('/^[0-9A-Za-z]{8,15}$/', $pass)){
  // BAD PASSWORD
}

[mike177]

You could use ctype as revraz suggested, but the problem with your first attempt was the wrong regexp:

([0-9A-Za-z])

 

1) Minor note, but the parens aren't needed.

 

2) The problem, that regexp matches a single alphanumeric character.  Add a + to it if you want it to match one or more.

 

[0-9A-Za-z]+

 

(edit) While I'm at it, might as well write the regexp to eliminate all of your if statements:

/^[0-9A-Za-z]{8,15}$/

That matches all alphanumeric strings 8 to 15 characters in length with no beginning or trailing white space.

 

if(!preg_match('/^[0-9A-Za-z]{8,15}$/', $pass)){
  // BAD PASSWORD
}

Cheers mate, Works a treat.