cgm225 Posted February 21, 2008 Share Posted February 21, 2008 How would you "combine" the two sections of code below to run all at once? They are are basically the same except for minor differences in variable name. I want to do this the best way possible. /*//////Adding any new images to the MySQL gallery database//////////////////////////////////////////// */ $number_of_image_files = count(glob("$server_photo_album_location/$album/*.*")); $number_of_mysql_image_entries = mysql_num_rows(mysql_query("SELECT * FROM images WHERE album = '$album_id'")); if ($number_of_image_files != $number_of_mysql_image_entries) { include_once "gallery.add.images.inc.php";} /*//////Adding any new videos to the MySQL gallery database//////////////////////////////////////////// */ $number_of_video_files = count(glob("$server_video_album_location/$album/*.*")); $number_of_mysql_video_entries = mysql_num_rows(mysql_query("SELECT * FROM videos WHERE album = '$album_id'")); if ($number_of_video_files != $number_of_mysql_video_entries) { include_once "gallery.add.videos.inc.php";} Link to comment https://forums.phpfreaks.com/topic/92206-consolidating-code/ Share on other sites More sharing options...
neylitalo Posted February 21, 2008 Share Posted February 21, 2008 That looks pretty efficient to me - you're dealing with two separate entities there (videos and images), so it's good that you have their logic separated. Link to comment https://forums.phpfreaks.com/topic/92206-consolidating-code/#findComment-472355 Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.