What's wrong with my code?

[ivytony]

The code I wrote is to save a domain name in the database. Before storing the domain, the code will check if it already existed. On the HTML page, there's a checkbox that allows duplicate domains, otherwise only one unique domain is allowed in the database.

 

Firstly, I created this function:

 

<?php
function duplicates($domain) { //check if the merchant already exists by looking at domain
	global $db;

	$n = $db->get_var("SELECT count(*) FROM domains WHERE domain = '$domain'");  //get_var is a function
	return $n;
}
?>

 

Below is to check the domain and store it:

<?php 
               $isduplicate = $_POST["duplicatedomain"];   // get the value of checkbox that allows duplicate domain
         if(duplicates($domain) > 0){   //if domain exists already
           
			if($isduplicate == 1){   //allows duplicate domain
			add_domain();   //a function to store the domain
             header("Location: admin_domains.php");
			}
			else{
		echo 'this domain already exists';
     	                exit;
			}
	 }
	 else{
      add_domain();
     header("Location: admin_domains.php");
	 }
?>

 

My problem is: no matter if the domain existed in database or not, it always stores the domain. I cannot figure out what's wrong.

[bpops]

First of all, you're missing a closing bracket on your if(){} statement in the first code.

[ivytony]

thanks, but there should be no if statement in the first code. I corrected it. sorry

[BlueSkyIS]

i don't know what $db is, presumably a data transfer object, so I can't tell what you get from $db->get_var("SELECT count(*) FROM domains WHERE domain = '$domain'");

 

you may not be getting an actual record or value, but instead a record set handle.