[SOLVED] Return not returning

[stuffradio]

I have this code that I'm starting to work on. When I try and return it, it won't print anything. When I echo it, everything is echoed.

 

<?php

class Template {

private $theme;
private $themeContents;

        function getTheme() {

        if (!$_GET['theme'] || $_GET['theme'] == "default") {
        ob_start();
$theme = file_get_contents(STYLE_DIR . "default/index.tpl");
$themeContents = ob_get_contents();
        ob_end_clean();
return $themeContents;
}

        }
}

?>

[trq]

Theres nothing in your buffer. No reason to be using one either.

 

<?php

class Template {

  private $theme;
  private $themeContents;

  function getTheme() {
    if (!$_GET['theme'] || $_GET['theme'] == "default") {
      return file_get_contents(STYLE_DIR . "default/index.tpl");
    }

  }

}

?>

[stuffradio]

So can you explain to me when I should use the ob functions?

[trq]

When you want to capture output into a buffer. file_get_contents does not output anything (it simply returns a string), so there is nothing to capture in a buffer.

[Daniel0]

You could use output buffering if your template file contained PHP code which had to be evaluated. Then you could use include() or require() instead of file_get_contents(). By doing so there would be output - output which you might have to capture using the output buffering functions.

[stuffradio]

That's weird Thorpe... I tried exactly what you said but it outputs nothing. Oh well, I'll just use echo for now.

[trq]

That's weird Thorpe... I tried exactly what you said but it outputs nothing. Oh well, I'll just use echo for now.

 

Can we see your calling code?

[stuffradio]

Sorry I didn't post again, what do you mean by calling code?

[keeB]

Whatever is using your object.

[stuffradio]

I think this is what you meant:

 

$display = new Template();

$display->getTheme();

[trq]

I think this is what you meant:

 

$display = new Template();

$display->getTheme();

 

Of course that won't output anything, as I said earlier, file_get_contents() returns a string, it does not output it. Try...

 

<?php

$display = new Template();
echo $display->getTheme();

?>

[stuffradio]

Awesome stuff man, you da man