[SOLVED] More efficient rewrite

[miless]

Is there any way to rewrite this code to make it more efficient ?

 

$host = gethostbyaddr($ip); // (usually returns something like blah.blah.blah.host.com)

if(
stristr($host,".host1.com") || 
stristr($host,".host2.com") || 
stristr($host,".host3.com") || 
stristr($host,".host4.com") || 
stristr($host,".host5.com") || 
stristr($host,".host6.com") || 
stristr($host,".host7.com") || 
stristr($host,".host8.com") || 
stristr($host,".host9.com") || 
stristr($host,".host10.com")){
exit;
}

[trq]

Probably not.

[thebadbad]

You can put the host names inside an array, and then loop through them. The code will be a bit shorter, but I don't think it will be faster (but strpos() is faster than stristr() nonetheless):

 

<?php
$host = strtolower(gethostbyaddr($ip)); // (usually returns something like blah.blah.blah.host.com)

$hosts = array('.host1.com', '.host2.com', '.host3.com', '.host4.com', '.host5.com', '.host6.com', '.host7.com', '.host8.com', '.host9.com', '.host10.com');

foreach ($hosts as $h) {
if (strpos($host, $h) !== false) {
	exit;
}
}
?>

 

Edit: Added strtolower().

[miless]

Thank you thebadbad. You can also scrap strtolower and use stripos if you use PHP5. Maybe even scrap !==false)

[DarkWater]

You need the !== false (Note the two == AND the !).  This is because if strpos finds the string at the first position, it returns zero, which is usually assumed false.