[SOLVED] problem inserting into mysql with fields from an array

[Poddy]

I am trying to get a dynamic form(one which you can add questions into) to post the dynamic questions, it fetches the questions from a questions database then inserts it into the form.

however on the processing of the form when i try inserting into the database all i get is 0 0 0 when the result is supposed to be 5 5 5

the post variables are working since i echoed them..

the problem seems to be with the query yet it does do the insert query but with the wrong data

 

<?php
$sql = "select `short` from `questions`";
$result = mysql_query($sql)	or die ('error 43' . mysql_error());
while ($row = mysql_fetch_assoc($result)) {
$short[] = $row['short'];
$varshort[] = "'$" . $row['short'] . "'";
}
$fields = implode(',',$short);
echo $fields . "<br />
";
$values = implode(',',$varshort);
echo $values;


$sql = "insert into `data` (name, spot, piret, text, $fields) VALUES ('$name', '$spot', '$piret', '$text', $values )";
mysql_query($sql) or die ('ERROR' . mysql_error());
?>

[hitman6003]

Not 100% sure what you're trying to accomplish...

 

while ($row = mysql_fetch_assoc($result)) {
$short[] = $row['short'];
$varshort[] = $$row['short'];
}

$fields = implode(',',$short);
echo $fields . "<br />
";

$values = implode("','",$varshort);
echo $values;

$sql = "insert into `data` (name, spot, piret, text, $fields) VALUES ('$name', '$spot', '$piret', '$text', '$values' )";

[.josh]

so..where are these vars being assigned?

 

$name

$spot

$piret

$text

[Poddy]

they were being assigned from a form, as i knew that part was fine i left it alone

anyway, thanks for your help

 

for some reason replacing $varshort[] = "'$" . $row['short'] . "'";

in $varshort[] = $$row['short'];

fixed the problem, as it was getting the variable name, and not the content.

 

thank you very much, you both

[DarkWater]

Poddy, it just magically populates those variables?  That must mean you have register_globals on.  Turn them off before the world explodes. D:  No, seriously.  They were turned off by default in PHP 4.2 or 4.3 (I forget) and they're completely out in PHP 6.  They're obsolete, so turn it off and code properly.