[SOLVED] whats wrong here

[serverman]

<?php
   $i = $r['cat_id'];
   switch ($i) 
   {
case 0:
    echo "nothing<br>";
    break;
case 1:
    echo '<img src="../img/php.gif" alt="" align="right"><br>';
    break;
?>

why doesnt it show the picture ... the switch works fine

[thebadbad]

What's the HTML source of the output, when $i is 1? Maybe the image path is wrong.

[thebadbad]

Arh, you're missing a closing bracket for the switch block.

[serverman]

here is the whole thing and yeah i is 1-5 never lands on 0... 0 means an error here is more of the script

$i = $r['cat_id'];
  switch ($i) 
  {
case 0:
   echo "nothing<br>";
   break;
case 1:
   echo '<img src="../img/php.gif" alt="" ><br>';
   break;
case 2:
   echo '<img src="../img/asp.gif" alt="" ><br>';
   break;
case 3:
   echo '<img src="../img/sql.gif" alt="" ><br>';
   break;
case 4:
   echo '<img src="../img/java.gif" alt="" ><br>';
   break;
case 5:
   echo '<img src="../img/html.gif" alt="" ><br>';
   break;	}

[serverman]

i dont know why but this fixed it

 {
case 0:
    echo "nothing<br>";
    break;
case 1:
  ?><img src="../img/php.gif" alt="" ><br><?php
    break;
case 2:
?><img src="../img/asp.gif" alt="" ><br><?php
    break;
case 3:
  ?><img src="../img/sql.gif" alt="" ><br><?Php
    break;
case 4:
  ?><img src="../img/java.gif" alt="" ><br><?php 
    break;
case 5:
   ?><img src="../img/html.gif" alt="" ><?php
    break;	}

[thebadbad]

Can't see anything wrong with it. And you're sure that the image path is right? I ask again: What is the output of the script (HTML source)? And the obvious question: Have you check that $i is not empty?? Your code is pretty repetitive. You can try:

 

<?php
$i = $r['cat_id'];
$cats = array('php', 'asp', 'sql', 'java', 'html');
if ($i > 0 && $i < 6) {
echo '<img src="../img/', $cats[$i - 1], '.gif" alt="" /><br />';
} elseif ($i == 0) {
echo 'nothing<br />';
}
?>

[serverman]

here it is http://67.235.135.133/tutorial/index.php working

im not shure why it works now but it does

it outputs the same thing without the change i made that fixed it but the pics didnt show up on firefox3

 

 

... now im going to try your fix it looks cleaner and like it will run faster

[thebadbad]

If it outputted the same thing, it would work if it does now.. weird?!

[serverman]

i have no clue why it didn't display but both ways work but your way is cleaner so im using it Thank you it works like a charm

[thebadbad]

Good