SPL Exceptions?

[RecoilUK]

Hi guys

 

Just wondering what your thoughts are on the exception handling introduced with the SPL, the throw new exception, try catch block method.

 

I just tried it for the first time and it creates a total mess, what was once clean and concise code is now full of try catch blocks.

 

Anyone else agree? do you use it? if not, what other methods do you use?

 

Thanks guys.

[DarkWater]

Well, exceptions are a major part of nearly every programming language.  If done properly, they're extremely useful.  If they're not done properly, they're annoying.

[Bauer418]

I agree.  Exceptions can be useful but they can be extremely annoying and pointless.  If your code is truly "full" of try catch blocks, you probably have too many.

[RecoilUK]

OK

 

This is what I have had to do, the first two were require_once but that doesnt work with exceptions so I had to swap them for includes.

 

<?php

try {
  if (!@include_once $_SERVER['DOCUMENT_ROOT'].'/classes/template.class.php') {
    throw new Exception("EXCEPTION : REQUIRED CLASS - TEMPLATE - NOT FOUND!!");
  }
}
catch (Exception $e) {
  echo $e->getMessage();
  die();
}

try {
  if (!@include_once $_SERVER['DOCUMENT_ROOT'].'/classes/database.class.php') {
    throw new Exception("EXCEPTION : REQUIRED CLASS - DATABASE - NOT FOUND!!");
  }
}
catch (Exception $e) {
  echo $e->getMessage();
  die();
}

$template = Template::Instance();
$db = Database::Instance();

try {
  $template->SetLayout('layout.html');
} 
catch (Exception $e) {
  echo 'EXCEPTION : ',  $e->getMessage(), "<BR>", $e->getFile(), "<BR> Line Number - ", $e->getLine(), "\n";
  die();
}

?>

 

Looks like a mess right?

[Bauer418]

Yes.  You don't need to use exceptions where you already have if statements.

 

This whole block:

try {
  if (!@include_once $_SERVER['DOCUMENT_ROOT'].'/classes/template.class.php') {
    throw new Exception("EXCEPTION : REQUIRED CLASS - TEMPLATE - NOT FOUND!!");
  }
}
catch (Exception $e) {
  echo $e->getMessage();
  die();
}

 

Will product the same results as this:

  if (!@include_once $_SERVER['DOCUMENT_ROOT'].'/classes/template.class.php') {
    print("EXCEPTION : REQUIRED CLASS - TEMPLATE - NOT FOUND!!");
    exit;
  }

[trq]

Just wondering what your thoughts are on the exception handling introduced with the SPL

 

Exceptions are not part of the SPL, they are in fact a part of the core since php5.

[DarkWater]

Oh yeah, I knew I forgot to point something out.  Thanks thorpe.  I read it and was like "It's not part of the SPL but I'm too lazy to post it."  =P