[SOLVED] Parse error. Please Help

[paulman888888]

Here is my code

<?php

$allowedPages = array('home', 'contact', 'about', 'artists');

for ($i =0; $i < sizeof($allowedPages); $i++) {
if ($_GET['where'] == $allowedPAges[$i])
include $_GET['where'] . '.php';
} else{//this is line 54
echo "Page not found or allowed.";
}
?>

 

And the error

Parse error: parse error, unexpected T_ELSE in /home/www/MYSITE.com/index.php on line 54

 

Please tell me what i have done wrong.

 

Thankyou

Paul

[rhodesa]

you don't have an open brace at the end of the if to match the one before the else:

 

<?php
$allowedPages = array('home', 'contact', 'about', 'artists');
  for ($i =0; $i < sizeof($allowedPages); $i++) {
    if ($_GET['where'] == $allowedPAges[$i]){
      include $_GET['where'] . '.php';
    } else{//this is line 54
      echo "Page not found or allowed.";
    }
  } //You were also missing one here
?>

[KevinM1]

Your if-statement doesn't have an opening brace.  Use:

$allowedPages = array('home', 'contact', 'about', 'artists');

for($i = 0; $i < sizeof($allowedPages); $i++)
{
   if($_GET['where'] == $allowedPages[i])
   {
      include $_GET['where'] . '.php';
   }
   else
   {
      echo "Page not found or allowed.";
   }
}

 

Just so you know, your code will echo "Page not found or allowed." if your $_GET value is anything other than 'home.'  So, if the 'artists' page is accessed, that error message will appear three times.

[rhodesa]

agreed...looks like you want something more like:

 

<?php
  $allowedPages = array('home', 'contact', 'about', 'artists');
  if(in_array($_GET['where'],$allowedPages)){
    include $_GET['where'] . '.php';
  }else{
    echo "Page not found or allowed.";
  }
?>

[DarkWater]

Yeah, you should definitely not use a for loop for something like that.  rhodesa had it with in_array().  And you should really indent your code better, it'll help you see syntax errors like that.