mysql and php, adding a returned var

[benphelps]

$count = "SELECT * FROM characters;";
while($row = mysql_fetch_array(mysql_query($count))){
$played = $row['totaltime']+$played;
}

 

This code is very slow, it loops adding the totaltime about 800 times.

 

Is there a faster method to do this, it currently takes about 6 min.

[revraz]

If you only want 'totaltime', just grab totaltime instead of *

 

$countchar = "SELECT totaltime FROM characters;";

 

[DarkWater]

Or:

 

#SQL
SELECT SUM(totaltime) AS total FROM characters;

[Mchl]

Also try running the query once instead of twice.

 

$countchar = "SELECT totaltime FROM characters;";
mysql_select_db('characters2');
$result = mysql_query($countchar);
$char2 = mysql_num_rows($result);
while($row = mysql_fetch_array($result)){
$played = $row['totaltime']+$played;
}

[DarkWater]

Omg, I didn't even notice that.  You run the query at least 800 times then because you put it in the loop!  You need to query before the loop so it gives the proper result set and saves memory!   Try:

 

$count = "SELECT SUM(totaltime) AS total FROM characters;";
$result = mysql_query($count) or die(mysql_error());
$row = mysql_fetch_array($result)
$played = $row['total'];

[benphelps]

missing ; but it works great, thanks guys

 

i just noticed myself that it runs the query every time.

[DarkWater]

missing ; but it works great, thanks guys

 

i just noticed myself that it runs the query every time.

 

Yeah, I noticed the missing ; too. xD  Woops.