[SOLVED] PHP Query Function

[jjacquay712]

I am trying to make a php function that does an sql query, then assigns the result to a variable that is global in the script. Heres an example:

 

<?php
myfunction("My SQL Query", $the_variable_that_contains_my_query);
echo $the_variable_that_contains_my_query;
?>

 

how would i go about making such a function?

 

                  Thanks, John

[genericnumber1]

it's bad practice to assign values globally in a function.

 

do

 

function query($query) {
   return mysql_query($query);
}

$result = query($query);

 

this function serves no purpose though, there's no reason not to just use mysql_query().

[DarkWater]

I wouldn't do this, but you could...Here's how:

 

function do_query($query, &$result) {
    $result = mysql_query($query) or die(mysql_error());
}

 

Whatever variable you pass into the function will be modified in the space in which it was declared.

[jjacquay712]

Im trying to make a function so my code will be less "dirty".

 

hers what i usually do:

 

$resource = mysql_query("blah blah blah") or die("");
$username = mysql_result($resource, 0, 'username');

 

but that takes up to much space, and if there's an error, it prints it on the page. with a function you could do a error_reporting(0); and suppress the error in only one part of the code.

[DarkWater]

1) Never use mysql_result().  Ever.  Honestly.

2) If there's an error on the page, you're doing it wrong.  Don't suppress the error, handle it properly.