[SOLVED] variable value goes missing

[kev wood]

i have a php script that uploads image to a server and stores the path to the image inside a mysql db which is working to an extent for me at the minute.  the problem i am having is that i am trying to perform an update on the mysql table with this script.  on the previous pages the user is asked to enter in the id number of the row they would like to update.

 

the number they choose is then passed through two pages which i am echoing out the number when the page first loads to make sure that it is being passed along.  the number that was chose is being echoed out at the top of the upload page but when i run the code it tells me that the variable is now empty when the update is run.

 

here is the code for passing the variables to the new pages

 

echo "<form action=\"$page\" method=\"post\">";
echo "<input type=\"hidden\" name=\"id_num\" value=\"$id\" />";
echo "<input type=\"submit\" value=\"Upload Image\"/>";
echo "</form>";

 

and here is the code i am using for the image upload (only the uodate not working)

 

<?php

$id_num = $_POST['id_num'];
echo "$id_num";    //echo's out the number from the previous page

set_time_limit(0); 

$link  =  mysql_connect(localhost, xxxxxxxx, xxxxxxx) or die("Could not connect to host.");
mysql_select_db(xxxxxxdb) or die("Could not find database.");




//define a maxim size for the uploaded images
define ("MAX_SIZE","500"); 
// define the width and height for the thumbnail
// note that theese dimmensions are considered the maximum dimmension and are not fixed, 
// because we have to keep the image ratio intact or it will be deformed
define ("WIDTH","150"); 
define ("HEIGHT","120"); 

// this is the function that will create the thumbnail image from the uploaded image
// the resize will be done considering the width and height defined, but without deforming the image
function make_thumb($img_name,$filename,$new_w,$new_h)
{
//get image extension.
$ext=getExtension($img_name);
//creates the new image using the appropriate function from gd library
if(!strcmp("jpg",$ext) || !strcmp("jpeg",$ext))
$src_img=imagecreatefromjpeg($img_name);

if(!strcmp("png",$ext))
$src_img=imagecreatefrompng($img_name);

if(!strcmp("gif",$ext))
$src_img=imagecreatefromgif($img_name);

//gets the dimmensions of the image
$old_x=imageSX($src_img);
$old_y=imageSY($src_img);

// next we will calculate the new dimmensions for the thumbnail image
// the next steps will be taken: 
// 	1. calculate the ratio by dividing the old dimmensions with the new ones
//	2. if the ratio for the width is higher, the width will remain the one define in WIDTH variable
//		and the height will be calculated so the image ratio will not change
//	3. otherwise we will use the height ratio for the image
// as a result, only one of the dimmensions will be from the fixed ones
$ratio1=$old_x/$new_w;
$ratio2=$old_y/$new_h;
if($ratio1>$ratio2)	{
$thumb_w=$new_w;
$thumb_h=$old_y/$ratio1;
}
else	{
$thumb_h=$new_h;
$thumb_w=$old_x/$ratio2;
}

// we create a new image with the new dimmensions
$dst_img=ImageCreateTrueColor($thumb_w,$thumb_h);
// resize the big image to the new created one
imagecopyresampled($dst_img,$src_img,0,0,0,0,$thumb_w,$thumb_h,$old_x,$old_y); 

// output the created image to the file. Now we will have the thumbnail into the file named by $filename
if(!strcmp("png",$ext))
imagepng($dst_img,$filename); 
else
imagejpeg($dst_img,$filename);

if (!strcmp("gif",$ext))
imagegif($dst_img,$filename); 

//destroys source and destination images. 
imagedestroy($dst_img); 
imagedestroy($src_img); 
}

// This function reads the extension of the file. 
// It is used to determine if the file is an image by checking the extension. 
function getExtension($str) {
$i = strrpos($str,".");
if (!$i) { return ""; }
$l = strlen($str) - $i;
$ext = substr($str,$i+1,$l);
return $ext;
}
// This variable is used as a flag. The value is initialized with 0 (meaning no error found) 
//and it will be changed to 1 if an error occures. If the error occures the file will not be uploaded.
$errors=0;
// checks if the form has been submitted
if(isset($_POST['Submit']))
{
//reads the name of the file the user submitted for uploading
$image=$_FILES['cons_image']['name'];
// if it is not empty
if ($image) 
{
// get the original name of the file from the clients machine
$filename = stripslashes($_FILES['cons_image']['name']);

// get the extension of the file in a lower case format
$extension = getExtension($filename);
$extension = strtolower($extension);
// if it is not a known extension, we will suppose it is an error, print an error message 
//and will not upload the file, otherwise we continue
if (($extension != "jpg")  && ($extension != "jpeg") && ($extension != "png") && ($extension != "gif"))	
{
echo '<h1>Unknown extension!  Please use .gif, .jpg or .png files only.</h1>';
$errors=1;
}
else
{
// get the size of the image in bytes
// $_FILES[\'image\'][\'tmp_name\'] is the temporary filename of the file in which 
//the uploaded file was stored on the server
$size=getimagesize($_FILES['cons_image']['tmp_name']);
$sizekb=filesize($_FILES['cons_image']['tmp_name']);

//compare the size with the maxim size we defined and print error if bigger
if ($sizekb > MAX_SIZE*1024)
{
echo '<h1>You have exceeded the 1MB size limit!</h1>';
$errors=1;
}


$rand= rand(0, 1000);
//we will give an unique name, for example a random number
$image_name=$rand.'.'.$extension;
//the new name will be containing the full path where will be stored (images folder)
$consname="image/".$image_name;
$consname2="image/thumb".$image_name;
$copied = copy($_FILES['cons_image']['tmp_name'], $consname);
$copied = copy($_FILES['cons_image']['tmp_name'], $consname2);
echo "$consname2<br/>";

$sql="UPDATE general SET image= '$consname2'  WHERE id= '$id_num'"or die(mysql_error());
$query = mysql_query($sql)or die(mysql_error());
							   
echo 'SQL: ' . $sql . '<br />Affected rows: ' . mysql_affected_rows($query);
//we verify if the image has been uploaded, and print error instead
if (!$copied) {
echo '<h1>Copy unsuccessfull!</h1>';
$errors=1;
}
else
{
// the new thumbnail image will be placed in images/thumbs/ folder
$thumb_name=$consname2	;
// call the function that will create the thumbnail. The function will get as parameters 
//the image name, the thumbnail name and the width and height desired for the thumbnail
$thumb=make_thumb($consname,$thumb_name,WIDTH,HEIGHT);
}
}	
}
}

//If no errors registred, print the success message and show the thumbnail image created
if(isset($_POST['Submit']) && !$errors) 
{
echo "<h5>Thumbnail created Successfully!</h5>";
echo '<img src="'.$thumb_name.'">';
}

echo "<form name=\"newad\" method=\"post\" enctype=\"multipart/form-data\"  action=\"\">";
echo "<input type=\"file\" name=\"cons_image\"  >";
echo "<input name=\"Submit\" type=\"submit\"  id=\"image1\" value=\"Upload image\" />";
echo "</form>";



?>

 

when this code is run i get this error

 

the id number is
image/thumb540.jpg
Warning: mysql_affected_rows(): supplied argument is not a valid MySQL-Link resource in /home/acmeart/public_html/lock/cms/cons_image2_up.php on line 171 SQL: UPDATE general SET image= 'image/thumb540.jpg' WHERE id= ''
Affected rows: 

 

any help would be great.

[kenrbnsn]

You showed us everything except how the value of $id get set.

 

Ken

[kev wood]

the variable is set from a text box held within a form here is the code for that

 

<form action="display.php" method="post">
ID number: <input type="text" name="id" /><br /><br>
<input type="hidden" name="dropdown2" value="<?=$db;?>"/>
<input type="hidden" name="radio2" value="<?=$table;?>"/> 
<input type="submit" value="Edit Article"/>
</form>

[kenrbnsn]

Do you ever do

<?php
$id = $_POST['id'];
?>

before using $id in the form? If not you're relying on register_globals being enabled, which hasn't been the case, in most places, for 4 or 5 years.

 

Ken

[Adam]

He does have it, right at the top..

 

$id_num = $_POST['id_num'];
echo "$id_num";    //echo's out the number from the previous page

 

But I think I see the problem..

 

echo "<form action=\"$page\" method=\"post\">";
echo "<input type=\"hidden\" name=\"id_num\" value=\"$id\" />";
echo "<input type=\"submit\" value=\"Upload Image\"/>";
echo "</form>";

 

Shouldn't the second line be:

echo "<input type=\"hidden\" name=\"id_num\" value=\"$id_num\" />";

 

??

 

Adam

 

[kev wood]

yes i post it from the first form with the name id when it get to the next page i post it across using a hidden form input, i originally had the same naming convention for the hidden input but changed it slightly so it was name id_num  with the value of $id.

 

on the last page i then use

$id_num = $_POST['id_num'];

 

to recall the data held in the variable id_num.  i have then echoed oout this variable whcih i have taken off on the code io have posted and it will print at the top of the screen the number entered in on the earlies page.

 

once the image upload code is run this variable the becomes empty.  i know the upload script works as i have used it on numerous occasions with no problems and it is also being used for the initial upload of the image. 

[Adam]

Ahh I see... Again it's a form problem, but with this one:

 

<form action="display.php" method="post">
ID number: <input type="text" name="id" /><br /><br>
<input type="hidden" name="dropdown2" value="<?=$db;?>"/>
<input type="hidden" name="radio2" value="<?=$table;?>"/>
<input type="submit" value="Edit Article"/>
</form>

 

<input type="text" name="id" /> - shouldn't that be "id_num" ? .. as in display.php you're getting the ID with:

 

$id_num = $_POST['id_num'];

 

Adam

[kev wood]

MrAdam:

 

i have posted it to the page holding this code

 

echo "<form action=\"$page\" method=\"post\">";
echo "<input type=\"hidden\" name=\"id_num\" value=\"$id\" />";
echo "<input type=\"submit\" value=\"Upload Image\"/>";
echo "</form>";

 

using this code

 

<form action="display.php" method="post">
ID number: <input type="text" name="id" /><br /><br>
<input type="hidden" name="dropdown2" value="<?=$db;?>"/>
<input type="hidden" name="radio2" value="<?=$table;?>"/> 
<input type="submit" value="Edit Article"/>
</form>

[kev wood]

i dont think it is a problem with the passing of the variables as when i load the last page the value held with the variable $id_num is echoed out at the top of the page.  even when the number is changed it still echoe's out the correct number.

 

the image upload takes place and then the variable has no value inside it then

[kenrbnsn]

We need to see more of your code, especially the code that processes the first form's input.

 

Before you do:

<?php
echo "<form action=\"$page\" method=\"post\">";
echo "<input type=\"hidden\" name=\"id_num\" value=\"$id\" />";
echo "<input type=\"submit\" value=\"Upload Image\"/>";
echo "</form>";
?>

echo out the value of $id & $_POST['id'].

 

Ken

[kev wood]

when the user enters the id number of the article that they would like to edit from the db the come to the display page.  on this page the user is presented with the information taken from the db depending on the id number they have entered.

 

the code for this section looks like this

 

echo "<h2>Edit the article here</h2>";
echo "<form action=\"update.php\" method=\"post\">";
echo "<b>Date:</b> <input type=\"text\" name=\"date\" value=\"{$row['date']}\" /><br /><br>";
echo "<b>Title:</b>  <input type=\"text\" name=\"title\" value=\"{$row['title']}\" /><br /><br />";
echo "<input type=\"hidden\" name=\"dropdown2\" value=\"$db\" />";
echo "<input type=\"hidden\" name=\"radio2\" value=\"$table\" />";
echo "<input type=\"hidden\" name=\"id\" value=\"$id\" />";
echo "<input type=\"hidden\" name=\"image\" value=\"{$row['image']}\" />";
echo "<b>Article:</b><br /><textarea cols=\"50\" rows=\"10\" name=\"article\" onkeyup=\"textLimit(this, 500)\">{$row['article']}</textarea><br /><br />";
echo "<input type=\"submit\" value=\"Save Article\"/>";
echo "</form>";

 

then directly underneath this is this code

 

echo "<h2>Edite the image</h2>";
echo "<form action=\"$page\" method=\"post\">";
echo "<input type=\"hidden\" name=\"id_num\" value=\"$id\" />";
echo "<input type=\"submit\" value=\"Upload Image\"/>";
echo "</form>";

[Adam]

can you not post the 2 files in question here as whole?? Makes it a lot easier than trying to piece it together..

 

Also a quick tip, wouldn't it be easier to output as HTML with PHP in it, rather than PHP with HTML in it?

 

Like say:

 

<b>Date:</b> <input type="text" name="date" value="<?php echo $row['date']; ?>" /><br /><br>

 

Adam

[kev wood]

the page before this code is executed above is where the value for the variable is entered by the user and the code for that is

 

<form action="display.php" method="post">
ID number: <input type="text" name="id" /><br /><br>
<input type="hidden" name="dropdown2" value="<?=$db;?>"/>
<input type="hidden" name="radio2" value="<?=$table;?>"/> 
<input type="submit" value="Edit Article"/>
</form>

[kev wood]

i have just sent you a pm with a link to the pages have a go at it you will that the number is being passed along the pages.  i will just make sure the echo is still at the top of the last page if not i wil upload it with it there.

[kenrbnsn]

Please post the entire scripts. We can't follow the flow when you're just posting snippets.

 

Ken

[kev wood]

check your pm i just passed you a link and an explanation of what you need to do.  i will post any code after you have had a look what my problem is. 

[kev wood]

i might have just fixed it i will let you know now.

[kev wood]

i feel like poking myself in the eye very hard.

 

the variables have been getting sent over to the last page and i new this because i was able to echo this out.  so i thought that as they where being sent to this page that they would automatically be available for use.  which i now know was not the case.  at the bottom of the page of php code is the button to process the page.  as the page was not redirected nowhere i did not think i would have to send the variable as hidden form values with that submit button but alas i did.  with the hidden for variables in at the bittom of the page it is processed as it should be.

 

i am happy now.

 

thank you for all your help especially MrAdam as you know this started on friday.  and i would just like to say to all those people from friday who kept insisting that the number could not be getting sent to the last page.  I TOLD YOU IT WAS.

 

and as i said on friday patience is a virtue that not all of us have.  and with a little bit of perseverance any goal can be reached.