[SOLVED] Numerous "if" statements -- cluttered code

[Adeus]

Hi, I would still consider myself a PHP novice. I have a question concerning best methods/practices. Would there be an easier/less cluttered way of doing something like this?

 

if (isset($_GET['item_1'])) { $_SESSION['item_1'] = $_GET['item_1']; } elseif (!isset($_SESSION['item_1'])) { $_SESSION['item_1'] = ""; }
if (isset($_GET['item_2'])) { $_SESSION['item_2'] = $_GET['item_2']; } elseif (!isset($_SESSION['item_2'])) { $_SESSION['item_2'] = ""; }
if (isset($_GET['item_3'])) { $_SESSION['item_3'] = $_GET['item_3']; } elseif (!isset($_SESSION['item_3'])) { $_SESSION['item_3'] = ""; }
//...and so on...

 

I have about 20 or so of these "if" statements sitting atop my script. There has to be a better way. Thanks for any references or help.

[JonnoTheDev]

use a loop

for($x = 1; $x <= 20; $x++) {
if(isset($_GET['item_'.$x])) { 
	$_SESSION['item_'.$x] = $_GET['item_'.$x]; 
} 
elseif(!isset($_SESSION['item_'.$x])) { 
	$_SESSION['item_'.$x] = ""; 
}
}

[gevans]

This is a bit cleaner and should work for you

 

<?php
$_SESSION['item_1'] = (isset($_GET['item_1']))? $_GET['item_1'] : "";
$_SESSION['item_2'] = (isset($_GET['item_2']))? $_GET['item_2'] : "";
$_SESSION['item_3'] = (isset($_GET['item_3']))? $_GET['item_3'] : "";
?>

[Adeus]

Thanks guys! Perhaps I could use both strategies and do something like this?

 

<?php 
for($x = 1; $x <= 20; $x++) {
   $_SESSION['item_'.$x] = (isset($_GET['item_'.$x])) ? $_GET['item_'.$x] : "";
}
?>

 

I'm going to give it a try.

[gevans]

Nice thinking batman!!!!

[Adeus]

Nice thinking batman!!!!

 

Haha, thanks. The "ternary loop" works fine. Much appreciated!