[SOLVED] mysql_num_rows error

[Exoon]

Hello,

 

Im getting an error when using this bit of code, Ive looked on php.net but can't see to find an anwser.

 

$sql = "SELECT * FROM links";
$result = mysql_query($sql) or die(mysql_error());
$num_rows = mysql_num_rows($result);

 

The error im getting is:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

[dclamp]

there is something wrong with your query, not the php.

 

try "SELECT * FROM `links` WHERE 1"

[Exoon]

i swaped it over to what you said.

 

$sql = "SELECT * FROM `links` WHERE 1"
$result = mysql_query($sql) or die(mysql_error());
$num_rows = mysql_num_rows($result);

 

and i now get the following error

 

Parse error: syntax error, unexpected T_VARIABLE in update_link_hits.php on line 6

 

Line 6 is the $result = mysql line

[trq]

Your now missing a ; from line 5.

[trq]

Just as an example, the query process should always be wrapped within if statements so as to catch any errors. eg;

 

$sql = "SELECT * FROM `links` WHERE 1";
if ($result = mysql_query($sql)) {
  if (mysql_num_rows($result)) {
    // its now safe to display any data.
  } else {
    // no results found.
  }
} else {
  // your query failed.
}

[Exoon]

Thanks, Its working now and thanks for the tip ill remember to do it from that now.