haaki Posted February 23, 2009 Share Posted February 23, 2009 Hi all, I appreciate your comments in earlier topics on my Travel Guide to Norway. The coding has now been vastly improved (I hope, I am not a professional), and I think the design is also a lot better than last time. All my changes so far have actually been inspired by your comments, so I am very grateful. I hope you will have some critique and comments to my new design: Norway Travel Guide at www.mynorwaytravelguide.org Thank you being so helpful! Quote Link to comment https://forums.phpfreaks.com/topic/146563-new-and-improved-again/ Share on other sites More sharing options...
jackpf Posted February 23, 2009 Share Posted February 23, 2009 I didn't actually see your first one, but this one looks cool. Nice colors, and good rounded corners However, it seems to wide for the page. You should try setting page width to 100%, if you've currently got it at a fixed value. Also, it doesn't validate. There are only a few errors, so it should be easy to fix. But really, it's worth making your code valid! Good luck. Quote Link to comment https://forums.phpfreaks.com/topic/146563-new-and-improved-again/#findComment-769439 Share on other sites More sharing options...
brown2005 Posted February 23, 2009 Share Posted February 23, 2009 i dont know if you meant it this way, but there is a large space to the left of the site. around 300px roughly... Quote Link to comment https://forums.phpfreaks.com/topic/146563-new-and-improved-again/#findComment-769532 Share on other sites More sharing options...
haaki Posted February 23, 2009 Author Share Posted February 23, 2009 Thanks for the quick feedback! Where / how do I check if my code validate? Quote Link to comment https://forums.phpfreaks.com/topic/146563-new-and-improved-again/#findComment-769606 Share on other sites More sharing options...
nrg_alpha Posted February 23, 2009 Share Posted February 23, 2009 Where / how do I check if my code validate? html validation: http://validator.w3.org/ css validation: http://jigsaw.w3.org/css-validator/ Quote Link to comment https://forums.phpfreaks.com/topic/146563-new-and-improved-again/#findComment-769635 Share on other sites More sharing options...
haaki Posted February 24, 2009 Author Share Posted February 24, 2009 Thanks, And then another beginner's question: What are the advantages of having a valid code when it works as it is? What exactly does it mean that it is valid? Does it matter if its not? I was just wondering.. Thanks for all help Quote Link to comment https://forums.phpfreaks.com/topic/146563-new-and-improved-again/#findComment-770455 Share on other sites More sharing options...
nrg_alpha Posted February 24, 2009 Share Posted February 24, 2009 What are the advantages of having a valid code when it works as it is? Invalid code leaves parsing interpretation to the browser in question. Depending on how bad the code is, the page may not render properly (but then again, it might). Therefore, do you really want to risk current (and future) browsers interpreting things their way and potentially have your site appear slightly (or badly, depending again on how bad your code is) broken to your visitors? What exactly does it mean that it is valid? Does it matter if its not? When something is coded to standards (that is to say, the code is valid) this simply means that the web developer has taken the time to ensure that the code conforms to W3C standards. W3C (World Wide Web Consortium) devises languages such as html and css by example, and urges web browser manufacturers to implement those standards, so that as long as a developer codes by those standards, it should work. And again, it might matter if bad code is not interpreted by the browser the way the developer intended. It's always best to simply learn how to build to standards. Quote Link to comment https://forums.phpfreaks.com/topic/146563-new-and-improved-again/#findComment-770546 Share on other sites More sharing options...
haaki Posted February 25, 2009 Author Share Posted February 25, 2009 thank you nrg_alpha, that was very informative. I have now validated the code on my index page and the main travel page. This is validated for transitional html (not strict). Are there advantages to choose the strict? It should be pretty quick to validate the rest since I don't think they have much of the errors as the main pages had. And while I'm at it; is there a way to "attach" one div to another? The blue column with "recent articles" is one div, and I'd like the orange picture below it (which is another div) to move down when I add more links to the blue div. Now it has a fixed position. I also had a similar problem with making a footer.. Quote Link to comment https://forums.phpfreaks.com/topic/146563-new-and-improved-again/#findComment-770716 Share on other sites More sharing options...
nrg_alpha Posted February 25, 2009 Share Posted February 25, 2009 You can read up about transitional vs strict here (as well as Googling it). Quote Link to comment https://forums.phpfreaks.com/topic/146563-new-and-improved-again/#findComment-770726 Share on other sites More sharing options...
nrg_alpha Posted February 25, 2009 Share Posted February 25, 2009 And while I'm at it; is there a way to "attach" one div to another? The blue column with "recent articles" is one div, and I'd like the orange picture below it (which is another div) to move down when I add more links to the blue div. Now it has a fixed position. You should get into the practice of floating divs instead of positioning them as you have done. By using css and floating your div (in this case, float: right), and then space it away from the div above it with margins, as that upper div expands in size (vertically), the one beneath it will simply shift down along as needed. Quote Link to comment https://forums.phpfreaks.com/topic/146563-new-and-improved-again/#findComment-770733 Share on other sites More sharing options...
DarkSuperHero Posted March 1, 2009 Share Posted March 1, 2009 only think i dont really like is the next image link make whole page refresh... :-( Quote Link to comment https://forums.phpfreaks.com/topic/146563-new-and-improved-again/#findComment-773543 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.