Jump to content

Form just prints all error msgs

blink359

By blink359
in PHP Coding Help

 Share

Recommended Posts

blink359 Regular Member

blink359

Posted
Posted

http://worldsofshadow.com/random/test.php

it just prints all error messages went you submit here is script 

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
<style type="text/css">
<!--
.style1 {font-size: small}
#apDiv1 {
position:absolute;
left:37px;
top:210px;
width:169px;
height:30px;
z-index:1;
}
body {
background-color: #999999;
}
.cssnav
{
position: relative;
font-family: arial, helvetica, sans-serif;
background: url(images/overbtn.jpg) no-repeat;
white-space: nowrap;
display: block;
width: 250px;
height: 50px;
margin: 0;
padding: 0;
}
.cssnav a
{
display: block;
color: #000000;
font-size: 11px;
width: 250px;
height: 50px;
display: block;
float: left;
color: black;
text-decoration: none;
}
.cssnav img
{
width: 250px;
height: 50px;
border: 0
}
* html a:hover
{
visibility:visible
}
.cssnav a:hover img
{
visibility:hidden
}
.cssnav span
{
position: absolute;
left: 53px;
top: 15px;
margin: 0px;
padding: 0px;
cursor: pointer;
width: 250px;
} 
.style4 {font-size: 16px}
-->
</style>
</head>
<body>
<center><table width="80%" border="1" align="center">
  <tr>
    <th height="186" colspan="5" align="left" valign="top" scope="row"><img src="file:///C|/Documents and Settings/Administrator/Desktop/Images/logo2.jpg" width="944" height="215" /></th>
  </tr>
  <tr>
    <th width="25%" rowspan="2" align="left" valign="top" scope="row"><h2>
      <div class="cssnav"><a href="index.html" title=""><img src="images/downbtn.jpg" alt="" /><span class="style4">Home</span></a></div>
      <div class="cssnav"><a href="Register.php" title=""><img src="images/downbtn.jpg" alt="" /><span class="style4">Create Account</span></a></div>
      <div class="cssnav"><a href="phpbb3/index.php" title=""><img src="images/downbtn.jpg" alt="" /><span class="style4">Forums</span></a></div>
      <div class="cssnav"><a href="vote.php" title=""><img src="images/downbtn.jpg" alt="" /><span class="style4">Vote</span></a></div>
      <div class="cssnav"><a href="donate.html" title=""><img src="images/downbtn.jpg" alt="" /><span class="style4">Donate</span></a></div>
      <div class="cssnav"><a href="character.html" title=""><img src="images/downbtn.jpg" alt="" /><span class="style4">Account Tools</span></a></div>

      <br />
      </h2>      </th>
    <td colspan="3" rowspan="3" valign="top"> 
      <center><form method="post" action="">
        <p>
          <?php 
$dbhost = "localhost";
$dbuser = "root";
$dbpass = "ascent";
$dbname = "logon";

mysql_connect($dbhost, $dbuser, $dbpass); 
mysql_select_db($dbname); 

$success = true; 
$problemMessage = ""; 
if (isset($_POST['Submit'])) 
{ 
        if(!$user || !$pass || !$pass2) 
        { 
            $problemMessage .= "Please complete all required data <br />"; 
            $success = false; 
        } 
        if(strlen($user) < 5) 
        { 
            $problemMessage .= "User must be more that 5 characters <br />"; 
            $success = false; 
        } 
        if(strlen($user) > 20) 
        { 
            $problemMessage .= "Your username cannot be longer than 20 characters <br />"; 
            $success = false; 
        } 
        if($pass != $pass2) 
        { 
            $problemMessage .= "Your passwords do not match <br />"; 
            $success = false; 
        } 
        if(strlen($pass2) < 5) 
        { 
            $problemMessage .= "Your password must be more than 5 characters<br />"; 
            $success = false; 
        } 
        if(strlen($pass2) > 20) 
        { 
            $problemMessage .= "Your password cannot be longer than 20 characters <br />"; 
            $success = false; 
        }  

    $result = mysql_query("SELECT * FROM `accounts` where login='{$_POST['user']}'") or die("Error: (" . mysql_errno() . ") " . mysql_error());
	$row = mysql_fetch_array( $result );
	if(isset($row))
	{
            $problemMessage .= "The username already exists <br />"; 
            $success = false; 
	}
         
        if ($success) 
        { 
            echo "Valid New Account Entry<br />";
            $result = mysql_query("INSERT INTO `accounts` VALUES ('', '{$_POST['user']}', '{$_POST['pass2']}', '', '', '0', '9', '', '', '{$_POST['flag']}', 'enUS', '0', '0', null);") or die("Error: (" . mysql_errno() . ") " . mysql_error());

        } 

	$row = mysql_fetch_array( $result );

} 
  
?> 
          <?php 
if ($success == false) { 
    echo $problemMessage; 
} 
?>
          Account Creation Page<br> 
          Username: 
          <input name="user" type="text"/>
          <br>  
          Password: 
          <input name="pass" type="text"/>
          <br>  
          Repeat Password: 
          <input name="pass2" tpye="text"/>
          <br />
          Pre TBC
          <input type="radio" name="flag" value="0">
            <br>
          TBC Enabled
          <input type="radio" name="flag" value="8">
          <br>
          Wotlk Enabled
          <input type="radio" name="flag" value="24">
          <br>
          
          <input name="Submit" type="submit" value="submit" /> 
            </p>
        <imput name="reset" type="reset" value="reset" /> 


</form></center></td>
    <td width="22%" height="114">Login to forums</td>
  </tr>
  <tr>
    <td height="129" valign="top"><p class="style1">Donate now to keep our server up</p>
      <p class="style1"><a href="http://www.paypal.com"><img src="Images/Paypal.png" width="207" height="87" /></a></p></td>
  </tr>
  <tr>
    <th height="224" valign="top" scope="row"><br /></th>
    <td><p> </p>      </td>
  </tr>
  <tr>
    <th height="33" colspan="5" scope="row"> </th>
  </tr>
</table>
</center>
</body>
</html>

Link to comment
https://forums.phpfreaks.com/topic/155889-form-just-prints-all-error-msgs/
Share on other sites
premiso Regular Member

premiso

Posted
Posted

Do you just not like to read or implement what people suggest?

 

This is the same exact question you posted earlier in a separate thread and the answer is the same as it was in this thread:

 

http://www.phpfreaks.com/forums/index.php/topic,249827.msg1170902.html#msg1170902

 

Looking at the code you posted here, you did not even bother to attempt to modify your script to work when REGISTER_GLOBALS is turned off as suggested.

premiso Regular Member

premiso

Posted
Posted 

if (isset($_POST['Submit'])) 
{ 
    $user = isset($_POST['user'])?$_POST['user']:false;
    $pass = isset($_POST['pass'])?$_POST['pass']:false;
    $pass2 = isset($_POST['pass2'])?$_POST['pass2']:false;
        if(!$user || !$pass || !$pass2)

 

That would solve your issue, by making sure the variables are set and have been sent. This is how you should check for any values being sent from a form.

 

The ? and : are the ternary operators which is a shortened IF/ELSE statement. If the field user from the form inside of the superglobal $_POST has been set then set $user to be that value, else set it to false.

 

This should be done with any value that is coming from the form that you want to access. As with register_globals being off, $user is not set until you explicitly set it. I would suggest reading on what exactly register_globals did to help you understand why you need to define the variables you are receiving from forms.

premiso Regular Member

premiso

Posted
Posted

Thanks also what guides books etc would you recomend to a PhP learner/newbie like myself ?

 

Good Programming and Web Design Books

 

Check out the above thread. I do not really know, I never used books or tutorials, I just always googled a script for what I wanted to create and looked at how it was done and then figured out a better way to do it. I also found new ways of doing different items by helping out in these forums.

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.