PHP_SELF error

david-remone123 · May 6, 2009

I am trying to use the script from the website http://www.designplace.org/scripts.php?page=1&c_id=25, and it works fine if I set the limit variable high so that only 1 page is needed.

However, if i need more than 1 page to display products, i get the following error:

Notice: Undefined variable: PHP_SELF in C:\wamp\www\search2.php on line 148

and it will only show me results from the first page. How can I fix this?

Thanks.

Ken2k7 · May 6, 2009

Can you post the code?

david-remone123 · May 6, 2009

Can you post the code?

<?php

  // Get the search variable from URL

  $var = @$_GET['q'] ;
  $trimmed = trim($var); //trim whitespace from the stored variable

// rows to return
$limit=10; 

// check for an empty string and display a message.
if ($trimmed == "")
  {
  echo "<p>Please enter a search...</p>";
  exit;
  }

// check for a search parameter
if (!isset($var))
  {
  echo "<p>We dont seem to have a search parameter!</p>";
  exit;
  }

//connect to your database ** EDIT REQUIRED HERE **
mysql_connect("localhost","username","password"); //(host, username, password)

//specify database ** EDIT REQUIRED HERE **
mysql_select_db("database") or die("Unable to select database"); //select which database we're using

// Build SQL Query  
$query = "select * from the_table where 1st_field like \"%$trimmed%\"  
  order by 1st_field"; // EDIT HERE and specify your table and field names for the SQL query

$numresults=mysql_query($query);
$numrows=mysql_num_rows($numresults);

// If we have no results, offer a google search as an alternative

if ($numrows == 0)
  {
  echo "<h4>Results</h4>";
  echo "<p>Sorry, your search: "" . $trimmed . "" returned zero results</p>";

// google
echo "<p><a href=\"http://www.google.com/search?q=" 
  . $trimmed . "\" target=\"_blank\" title=\"Look up 
  " . $trimmed . " on Google\">Click here</a> to try the 
  search on google</p>";
  }

// next determine if s has been passed to script, if not use 0
  if (empty($s)) {
  $s=0;
  }

// get results
  $query .= " limit $s,$limit";
  $result = mysql_query($query) or die("Couldn't execute query");

// display what the person searched for
echo "<p>You searched for: "" . $var . ""</p>";

// begin to show results set
echo "Results";
$count = 1 + $s ;

// now you can display the results returned
  while ($row= mysql_fetch_array($result)) {
  $title = $row["1st_field"];

  echo "$count.) $title" ;
  $count++ ;
  }

$currPage = (($s/$limit) + 1);

//break before paging
  echo "<br />";

  // next we need to do the links to other results
  if ($s>=1) { // bypass PREV link if s is 0
  $prevs=($s-$limit);
  print " <a href=\"$PHP_SELF?s=$prevs&q=$var\"><< 
  Prev 10</a>&nbsp ";
  }

// calculate number of pages needing links
  $pages=intval($numrows/$limit);

// $pages now contains int of pages needed unless there is a remainder from division

  if ($numrows%$limit) {
  // has remainder so add one page
  $pages++;
  }

// check to see if last page
  if (!((($s+$limit)/$limit)==$pages) && $pages!=1) {

  // not last page so give NEXT link
  $news=$s+$limit;

  echo " <a href=\"$PHP_SELF?s=$news&q=$var\">Next 10 >></a>";
  }

$a = $s + ($limit) ;
  if ($a > $numrows) { $a = $numrows ; }
  $b = $s + 1 ;
  echo "<p>Showing results $b to $a of $numrows</p>";
  
?>

PFMaBiSmAd · May 6, 2009

$PHP_SELF was depreciated long ago in php4.2 in the year 2002. In most cases you can simply remove it (nothing in a URL refers to the current page) or replace it with $_SERVER['PHP_SELF']

david-remone123 · May 6, 2009

$PHP_SELF was depreciated long ago in php4.2 in the year 2002. In most cases you can simply remove it (nothing in a URL refers to the current page) or replace it with $_SERVER['PHP_SELF']

Thanks.

I took it out and i don't get the notice error anymore, but I can't display the 2nd page of products. And when I put in the SERVER code instead I get:

Parse error: parse error, expecting `T_STRING' or `T_VARIABLE' or `T_NUM_STRING' in C:\wamp\www\search2.php on line 128

How can I make the code work so that I can display say 3 pages with 3 items on each?

Ken2k7 · May 6, 2009

What is on line 128?

PFMaBiSmAd · May 6, 2009

Cannot really help you without seeing the code that resulted when you removed it or when you replaced it.

david-remone123 · May 6, 2009

What is on line 128?

I tried replacing the PHP_SELF with the thing earlier said:

line 128:

  echo " <a href=\"$_SERVER['PHP_SELF']?s=$prevs&q=$var\"><<

Ken2k7 · May 6, 2009

  echo " <a href=\"{$_SERVER['PHP_SELF']}?s=$prevs&q=$var\"><<";

Does your echo closes the "?

david-remone123 · May 6, 2009

  echo " <a href=\"{$_SERVER['PHP_SELF']}?s=$prevs&q=$var\"><<";

Does your echo closes the "?

Sorry, I mean yes i have:

  // next we need to do the links to other results
  if ($s>=1) { // bypass PREV link if s is 0
  $prevs=($s-$limit);
  echo " <a href=\"$_SERVER['PHP_SELF']?s=$prevs&q=$var\"><< 
  Prev 10</a>&nbsp ";
  }

Ken2k7 · May 6, 2009

Mind posting the updated code rather than one line?

david-remone123 · May 6, 2009

<html>

<head>

<title> www.sports-r-us.co.uk </title>

<link rel="stylesheet" type="text/css" href="registerpage.css"/>

</head>


<body>

<div id="site" align="center">

<div id="header">
<div class="text">
<a href="sitemap.php">SiteMap</a>
<a href="contactus.php">ContactUs</a>
<a href="help.php">Help</a>
</div>
</div>

<div id="navbar">

	<div class="text">
	<a href="user_Home.php">Home</a> 
	<a href="product-catalogue.php">ProductCatalogue</a> 
	<a href="search.php">Search</a> 
	<a href="browse.php">BrowseByCategory</a> 
	<a href="basket.php">Basket</a> 
	<a href="logout.php">Logout</a>  
	</div> 
</div>

<?php

  // Get the search variable from URL

  $var = @$_GET['q'] ;
  $trimmed = trim($var); //trim whitespace from the stored variable

// rows to return
$limit=3; 

// check for an empty string and display a message.
if ($trimmed == "")
  {
  echo "<p>Please enter a search...</p>";
  exit;
  }

// check for a search parameter
if (!isset($var))
  {
  echo "<p>We dont seem to have a search parameter!</p>";
  exit;
  }

//connect to your database ** EDIT REQUIRED HERE **
mysql_connect("localhost","root",""); //(host, username, password)

//specify database ** EDIT REQUIRED HERE **
mysql_select_db("dh-ecommerce2") or die("Unable to select database"); //select which database we're using

// Build SQL Query  
$query = "select * from products where productName like \"%$trimmed%\"  
  order by productCode"; // EDIT HERE and specify your table and field names for the SQL query

$numresults=mysql_query($query);
$numrows=mysql_numrows($numresults);

// If we have no results, offer a google search as an alternative

if ($numrows == 0)
  {
  echo "<h4>Results</h4>";
  echo "<p>Sorry, your search: "" . $trimmed . "" returned zero results</p>";

// google
echo "<p><a href=\"http://www.google.com/search?q=" 
  . $trimmed . "\" target=\"_blank\" title=\"Look up 
  " . $trimmed . " on Google\">Click here</a> to try the 
  search on google</p>";
  }

// next determine if s has been passed to script, if not use 0
  if (empty($s)) {
  $s=0;
  }

// get results
  $query .= " limit $s,$limit";
  $result = mysql_query($query) or die("Couldn't execute query");

// display what the person searched for
echo "<p>You searched for: "" . $var . ""</p>";

// begin to show results set
echo "<font color=\"white\">Results:</font> </br></br>";
$count = 1 + $s ;

// now you can display the results returned
  while ($row= mysql_fetch_array($result)) {
  $productName = $row["productName"];
  $productLine = $row["productLine"];
  $productDescription = $row["productDescription"];
  $image = $row["image"];
  $sellPrice = $row["sellPrice"];

  echo "<font color=\"white\"><u>$count.) $productName</u></b><br><br>$productLine<br><br></font>";
  echo "<img alt=\"product image\" width=\"250\" height=\"265\" src=\"images/".$image." \"/>";
  echo "<font color=\"white\"></br><u>Product Description</u><br><br>$productDescription<br><br>£$sellPrice<hr color='gray' width='35%'></hr><br></font>";

  
  //echo "$count.) $productName</br>$productLine</br>" ;
  $count++ ;
  }

$currPage = (($s/$limit) + 1);

//break before paging
  echo "<br />";

  // next we need to do the links to other results
  if ($s>=1) { // bypass PREV link if s is 0
  $prevs=($s-$limit);
  echo " <a href=\"$_SERVER['PHP_SELF']?s=$prevs&q=$var\"><< 
  Prev 10</a>&nbsp ";
  }

// calculate number of pages needing links
  $pages=intval($numrows/$limit);

// $pages now contains int of pages needed unless there is a remainder from division

  if ($numrows%$limit) {
  // has remainder so add one page
  $pages++;
  }

// check to see if last page
  if (!((($s+$limit)/$limit)==$pages) && $pages!=1) {

  // not last page so give NEXT link
  $news=$s+$limit;

  echo " <a href=\"$PHP_SELF?s=$news&q=$var\">Next 10 >></a>";
  }

$a = $s + ($limit) ;
  if ($a > $numrows) { $a = $numrows ; }
  $b = $s + 1 ;
  echo "<p>Showing results $b to $a of $numrows</p>";
  
?>

<div id="footer">
</div>
</div>	
</html>

Ken2k7 · May 6, 2009

Wow.. please read Forum DOs #4 - http://www.phpfreaks.com/page/rules-and-terms-of-service#toc_forum_dos

Nevermind... Saw the updated code.

premiso · May 6, 2009

As was pointed out above:

  echo " <a href=\"{$_SERVER['PHP_SELF']}?s=$prevs&q=$var\"><<
  Prev 10</a>&nbsp ";

Notice the { and } around $_SERVER['PHP_SELF']

Ken2k7 · May 6, 2009

You also missed one:

  echo " <a href=\"$PHP_SELF?s=$news&q=$var\">Next 10 >></a>";

It's a few lines below the previous one.

david-remone123 · May 6, 2009

As was pointed out above:
  echo " <a href=\"{$_SERVER['PHP_SELF']}?s=$prevs&q=$var\"><<
  Prev 10</a>&nbsp ";
Notice the { and } around $_SERVER['PHP_SELF']

I've done that too, and just got the same message as i got in the first place:

Notice: Undefined variable: prevs in C:\wamp\www\search2.php on line 148

Ken2k7 · May 6, 2009

You also missed one:
  echo " <a href=\"$PHP_SELF?s=$news&q=$var\">Next 10 >></a>";
It's a few lines below the previous one.

You left one out.

premiso · May 6, 2009

     <?php

  // Get the search variable from URL

  $var = isset($_GET['q'])?$_GET['q']:''; // use isset instead of @ operator as @ just suppresses errors which should not be done
  $trimmed = trim($var); //trim whitespace from the stored variable
  $prevs = 0; // define $prevs since it is used later on to prevent a notice error message.

It is often good practice to define your variables that may or may not be initiated but used in the script. That should remove the notice error for that variable.

david-remone123 · May 6, 2009

     <?php

  // Get the search variable from URL

  $var = isset($_GET['q'])?$_GET['q']:''; // use isset instead of @ operator as @ just suppresses errors which should not be done
  $trimmed = trim($var); //trim whitespace from the stored variable
  $prevs = 0; // define $prevs since it is used later on to prevent a notice error message.
It is often good practice to define your variables that may or may not be initiated but used in the script. That should remove the notice error for that variable.

Yep thats got rid of the notice errors, thankyou.

My page still says, for example:

Next 3 >>

Showing results 1 to 3 of 8

And wont let me go to results 4-6. Any ideas?

Sign In

PHP_SELF error

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Join the conversation

Important Information