[SOLVED] data2file

[jmr3460]

I am trying to get this script to work. Where have I gone wrong. This file writes the first string of the first row only. What did I do wrong?

 

<?php
include("dbin.php");
$table = "home";
mysql_connect($host, $user, $pass);
mysql_select_db($database) or die(mysql_error());
$data = mysql_query("SELECT id FROM $table");
$info = mysql_fetch_array($data);
$log = $info['id'] . " | " . $info['ip'] . " | " . $info['time'] . " | " . $info['browser'];
$filename = 'log.txt';
if (is_writable($filename)) {
    if (!$handle = fopen($filename, 'a')) {
         echo "Cannot open file ($filename)";
         exit;
    }
    while (fwrite($handle, $log) === FALSE) {
        echo "Cannot write to file ($filename)";
        exit;
    }
    echo "Success, wrote () to file " . $filename;
    fclose($handle);
} else {
    echo "The file $filename is not writable";
}
?>

[taquitosensei]

try doing a "\r\n" at the end of each line.  That's line break for *nix and Windows.

[jmr3460]

Yea that worked to make a new line on the text file but I still can't get anything but the first row and the first value of the array.

[Maq]

You only write to the file once.  I think you want to loop through the array of results:

 

while($info = mysql_fetch_array($data))
{

 

Don't forget the closing curly bracket.

[jmr3460]

Thanks that got all the rows in the DB. Why is it only pulling out the first value of the array?

[Maq]

You mean it's just pulling the 'id'?

 

You need to SELECT what you want to pull out.  Change this line to:

 

$data = mysql_query("SELECT * FROM $table");

[jmr3460]

Thank you very very much. It was so simple.

Things are coming together very nicely.

Thanks again. You have helped me a time or two before.