little problem.

[seany123]

does this code look right?

 

if($player->staff != 1 || $player->staff != 4 || $player->staff != 5){

 

is there no way of writing it in a better way?

[MasterACE14]

does this code look right?

yep

 

is there no way of writing it in a better way?

don't think so

[gevans]

you could do this;

 

<?php
$allowed_numbers = array(1, 4, 5);
if(!in_array($player->staff, $allowed_numbers)) {

 

Then if you want to add more numbers, just add to the array, rather than the conditional statement.

[dzelenika]

if(!($player->staff != 1 && $player->staff != 4 && $player->staff != 5)){

 

 

De Morgan's rules (Math):

 

!a && !b  <==> !(a || b)

 

!a || !b  <==> !(a && b)

[seany123]

but for example with this code..

 

if($player->staff != 1 || $player->staff != 4 || $player->staff != 5){
header("location: home.php");
}

 

it will redirect unless $player->staff is equal to 1, 4 or 5??

 

 

because i echo'd my $player->staff and it echo'd 5 so i shouldnt be redirected but i am.

 

[gevans]

Your using OR. When it's set to 5, not equla to 1 and not equal to 4 return true.

 

Change || to &&, or use my suggestion

[Adam]

Could shorten it a bit, looks best way to go using an array though...

 

if (!in_array($player->staff, array(1, 4, 5))) {