[SOLVED] unexpected {

[acctman]

i know the bracet is needed and the query above looks fine or am i missing something?

 

while ($line = mysql_fetch_array(mysql_query("SELECT rm.m_user, rm.m_id, rm.m_date, rp.i_id FROM rate_members AS rm LEFT JOIN rate_pictures AS rp ON rm.m_id = rp.i_user WHERE rm.m_type=1 AND rp.i_private=0 AND rm.m_del != 1 AND rp.i_status=2")) 
{

echo "<li id=\"mycarousel-item-1\">\n"
. "\t <a href=\"http://" . $line['m_user'] . ".site.com\" />\n"
. "\t <img width=50 height=50 src=\"/files/pvtexp.php?mid=" . $line['m_id'] . "&iid=" . $line['i_id'] . "&idat=" . date("Y", $line['m_date']) . "/" . date("m", $line['m_date']) . "&sec=3&sm=1\" title=" . $line['m_user'] . "/>\n"
. "\t </a>\n"
. "\t </li>\n";
}

[mmarif4u]

Should it not be three braces to end the while...

($line = mysql_fetch_array(mysql_query("SELECT rm.m_user, rm.m_id, rm.m_date, rp.i_id FROM rate_members AS rm LEFT JOIN rate_pictures AS rp ON rm.m_id = rp.i_user WHERE rm.m_type=1 AND rp.i_private=0 AND rm.m_del != 1 AND rp.i_status=2")))

[Maq]

Missing a closing ')' in your while clause.

[PFMaBiSmAd]

That while() loop will execute forever (making it a forever() loop) because the query is being executed over and over, returning the same results each time the loop is evaluated.

 

DON'T nest functions like that and you must execute the query before the start of the loop and only retrieve data in the loop.

[mmarif4u]

That while() loop will execute forever (making it a forever() loop) because the query is being executed over and over, returning the same results each time the loop is evaluated.

 

DON'T nest functions like that and you must execute the query before the start of the loop and only retrieve data in the loop.

 

Good point.

[acctman]

That while() loop will execute forever (making it a forever() loop) because the query is being executed over and over, returning the same results each time the loop is evaluated.

 

DON'T nest functions like that and you must execute the query before the start of the loop and only retrieve data in the loop.

 

so i would do something like this...

 

$res = mysql_fetch_array(mysql_query("SELECT rm.m_user, rm.m_id, rm.m_date, rp.i_id FROM rate_members AS rm LEFT JOIN rate_pictures AS rp ON rm.m_id = rp.i_user WHERE rm.m_type = '1' AND rp.i_private = 0 AND rm.m_del != 1 AND rp.i_status=2 LIMIT 24"));
foreach ($res as $line) {

[ignace]

That while() loop will execute forever (making it a forever() loop) because the query is being executed over and over, returning the same results each time the loop is evaluated.

 

DON'T nest functions like that and you must execute the query before the start of the loop and only retrieve data in the loop.

 

so i would do something like this...

 

$res = mysql_fetch_array(mysql_query("SELECT rm.m_user, rm.m_id, rm.m_date, rp.i_id FROM rate_members AS rm LEFT JOIN rate_pictures AS rp ON rm.m_id = rp.i_user WHERE rm.m_type = '1' AND rp.i_private = 0 AND rm.m_del != 1 AND rp.i_status=2 LIMIT 24"));
foreach ($res as $line) {

 

No. Sometihng like this:

$query = mysql_query("SELECT rm.m_user, rm.m_id, rm.m_date, rp.i_id FROM rate_members AS rm LEFT JOIN rate_pictures AS rp ON rm.m_id = rp.i_user WHERE rm.m_type = '1' AND rp.i_private = 0 AND rm.m_del != 1 AND rp.i_status=2 LIMIT 24");
while ($row = mysql_fetch_assoc($query)) {

 

And PFMaBiSmAd how do you know all this stuff? Or you wrote php or you have made the mistake once yourself. Because some stuff you tell just isn't covered in the manual But true nevertheless. I think you breath stdin and stdout.