[SOLVED] Stuck at an "unexpected $end"

[jamcoupe]

I am just trying to make a simple news script. I am trying to display all the news posts and their comments underneath them. Any ideas why I am getting:

Parse error: syntax error, unexpected $end in /Applications/MAMP/htdocs/jstar/test.php on line 69

 

Heres my code:

<?php
require("constants.php");

$connection = mysql_connect(DB_SERVER,DB_USER,DB_PASS);
query_check($connection);


$db_select = mysql_select_db(DB_NAME, $connection);
query_check($db_select);
?>
<?php
function query_check($check) {
if(!$check) {
	die ("OOOPS: " . mysql_error());
}
}

function get_news() {
global $connection;
$query = ("SELECT * FROM news ORDER BY id ASC");
query_check($query);
$news = mysql_query($query, $connection);
return $news;
}

function get_comments($id) {
global $connection;
$query = ("SELECT * FROM comments WHERE newsid = {$id} ORDER BY id ASC");
query_check($query);
$comments = mysql_query($query, $connection);
return $comments;
}

//This will enable 
function get_news_id($news_id) {
global $connection;
$query = ("SELECT * FROM news WHERE id={$news_id} LIMIT 1");
$query = mysql_query($query, $connection);
query_check($query);
if($id = mysql_fetch_array($query)) {
	return $id;
} else {
	return NULL;
}
}
?>
<?php

$get_news = get_news();

while ($news = mysql_fetch_array($get_news)) {
	echo "{$news['title']}<br />";

	$get_comments = get_comments($news['id']);

	while ($comments = mysql_fetch_array($get_comments)) {
		echo "{$comments['comment]}<br />";
	}
}

?>
<?php
if(isset($connection)) {
mysql_close($connection);	
}
?>

[abazoskib]

i dont see any syntax errors in what you posted, well as far as php -l is concerned.

[jarvis]

Is that test.php or does test.php call in the above?

[jamcoupe]

The script is test.php sorry I didnt say in the first post

[wildteen88]

There is no problems with that script. Your code works fine.

 

However I do not see the point in doing

<?php

// some php code here
?>
<?php

// some more php code here

?>

 

If you're not going to put anything between the code blocks then there is no need to go out of php and then immediately back in to php.

 

[Mark Baker]

Is this the entire script, or just the PHP part... have you stripped anything out from between the ?> and <?php

[jamcoupe]

Ahhhhhh I figured our the problem...

 

It was the line.

echo "{$comments[comment]}<br />";

 

Should have been.

echo "{$comments['comment']}<br />";

 

and that was the entire script.