bag Posted December 9, 2009 Share Posted December 9, 2009 Users have the capability of entering URLs and I have used the following $pattern = "^(https?|ftp)\:\/\/([a-z0-9+!*(),;?&=\$_.-]+(\:[a-z0-9+!*(),;?&=\$_.-]+)?@)?[a-z0-9+\$_-]+(\.[a-z0-9+\$_-]+)*(\:[0-9]{2,5})?(\/([a-z0-9+\$_-]\.?)+)*\/?(\?[a-z+&\$_.-][a-z0-9;:@/&%=+\$_.-]*)?(#[a-z_.-][a-z0-9+\$_.-]*)?\$"; if ( preg_match($pattern, $url) == FALSE ) { It got a bit out of hand and I'm lost. This one fails to validate valid urls and url validation must be something that has been done to death. Link to comment https://forums.phpfreaks.com/topic/184521-does-anyone-have-a-function-for-validating-url-entry/ Share on other sites More sharing options...
JAY6390 Posted December 9, 2009 Share Posted December 9, 2009 why not just use filter_var() with the FILTER_VALIDATE_URL parameter? Link to comment https://forums.phpfreaks.com/topic/184521-does-anyone-have-a-function-for-validating-url-entry/#findComment-974104 Share on other sites More sharing options...
cags Posted December 9, 2009 Share Posted December 9, 2009 I've not really looked at your pattern in any detail, but it should throw an error. PCRE patterns (ie preg_ functions) require delimiters. A search on google for validating URL should turn up millions of possible patterns, it mainly depends on how accurate you wish to be and which URLs you wish to support ie protocols (http://, ftp:// etc), domains (.co.uk, .info etc), parameters (?id=10&name=bob) and so on. If you are using PHP 5.2 or newer then it would probably make more sense to use filter_var as suggested by JAY6390. Link to comment https://forums.phpfreaks.com/topic/184521-does-anyone-have-a-function-for-validating-url-entry/#findComment-974107 Share on other sites More sharing options...
salathe Posted December 9, 2009 Share Posted December 9, 2009 … it mainly depends on how accurate you wish to be and which URLs you wish to support ie protocols (http://, ftp:// etc), domains (.co.uk, .info etc), parameters (?id=10&name=bob) and so on. … it would probably make more sense to use filter_var as suggested by JAY6390. With regards to the filter extension, the quoted portion of your first paragraph is just as relevant as with the regex approach. The FILTER_VALIDATE_URL filter will accept a wide variety of URLs and it's likely the application will want to accept a subset only. That said, for a first-step the filter works as advertised. Just to clarify, FILTER_VALIDATE_URL will happily accept URLs like the following (and many more): abcdefghjiklmnopqrstuvwxz://. foo://! news: file:_=~-_$.$_-~=_ .://. Link to comment https://forums.phpfreaks.com/topic/184521-does-anyone-have-a-function-for-validating-url-entry/#findComment-974125 Share on other sites More sharing options...
JAY6390 Posted December 9, 2009 Share Posted December 9, 2009 Yup. It may also be worth looking into parse_url() to check portions of the url are as you wish (such as the scheme) Link to comment https://forums.phpfreaks.com/topic/184521-does-anyone-have-a-function-for-validating-url-entry/#findComment-974127 Share on other sites More sharing options...
bag Posted December 9, 2009 Author Share Posted December 9, 2009 Thanks for the quick responses. We are on 5.1 here but I'll look at the parse_url function. That looks like something I could deal with instead of those patterns. Link to comment https://forums.phpfreaks.com/topic/184521-does-anyone-have-a-function-for-validating-url-entry/#findComment-974130 Share on other sites More sharing options...
JAY6390 Posted December 9, 2009 Share Posted December 9, 2009 It certainly does make easy work of urls, and means you don't need those messy regexes for them Link to comment https://forums.phpfreaks.com/topic/184521-does-anyone-have-a-function-for-validating-url-entry/#findComment-974134 Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.