Why won't the row delete?

[ianco]

Hey all. I'm trying to delete a row from a table using a drop down menu. The code in the mysql must be wrong but i can't see where. Here's the code. Any Ideas?

 

 <?php


$con = mysql_connect("localhost","user","password");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("databasename", $con);

$sql="SELECT Name, Paid FROM Stag";
$result=mysql_query($sql);

$options="";

while ($row=mysql_fetch_array($result)) {

    $Name=$row["Name"];
    $thing=$row["Paid"];
    $options.="<OPTION VALUE=\"$Name\">".$Name."</option>";
}
?>
<br>
<form action="http://xxxxxxx/delstag.php" method="post">
<SELECT NAME=thing>
<OPTION VALUE=0>Choose
<?=$options?>
</SELECT> 
<input type="submit" />
</form>     

$result = mysql_query("DELETE FROM Stag WHERE Name = $Name");

[Maq]

First all you need single quotes around $name because, presumably, it is a string.  See if that fixes the problem.

[ianco]

THe name in the mysql code? no that hasnt changed anything.

[ianco]

and <OPTION VALUE=\'$Name\'> doesnt work

[Ken2k7]

 

He meant in the SQL.

[ianco]

Yeah that's not doing anything i'm afraid

 

$result = mysql_query("DELETE FROM Stag WHERE Name = '$Name'");

 

Do I need $Name = $_POST['Name']; or is this irrelevant?

 

 

 

[Maq]

If you're passing the value from the form the next page via POST, the 'delstag.php' your code should look something like:

 

$Name = mysql_real_escape_string($_POST['thing']);
if (!$result = mysql_query("DELETE FROM Stag WHERE Name = '$Name'"))
{
   throw new Exception('Error: ' . mysql_error());
}
else
{
   echo $Name . " has been deleted.";
}

 

 

 

He meant in the SQL.

 

And yes, I meant the SQL.  But your HTML should have quotes around attribute values as well.

 

[ianco]

Haha, Maq, that code did the job.

 

Thank you very much