heyhey01 Posted May 4, 2010 Share Posted May 4, 2010 Hi i created this code below for user to register up till last night it was working but now it will not add people to my database when they register. Can anyone spot why this would be the case in the code below. I have changed the name of the database, password and host changed names of other things for posting on here. <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html> <head> <meta http-equiv="Content-type" content="text/html;charset=UTF-8"> <meta name="author" content=""> <title>SIGN UP</title> <link rel="stylesheet" type="text/css" href="css1.css" /> </head> <body> <?php error_reporting(0); // Connects to your Database mysql_connect("localhost", "yyyy", "ttt") or die(mysql_error()); mysql_select_db("fg") or die(mysql_error()); //This code runs if the form has been submitted if (isset($_POST['submit'])) { //This makes sure they did not leave any fields blank if (!$_POST['username'] | !$_POST['pass'] | !$_POST['pass2'] ) { die('You did not complete all of the required fields'); } // checks if the username is in use if (!get_magic_quotes_gpc()) { $_POST['username'] = addslashes($_POST['username']); } $usercheck = $_POST['username']; $check = mysql_query("SELECT username FROM members WHERE username = '$usercheck'") or die(mysql_error()); $check2 = mysql_num_rows($check); } // this makes sure both passwords entered match if ($_POST['pass'] != $_POST['pass2']) { die('Your passwords did not match. '); } // here we encrypt the password and add slashes if needed //if the name exists it gives an error if ($check2 != 0) { die('Sorry, the username '.$_POST['username'].' is already in use.'); $_POST['pass'] = md5($_POST['pass']); if (!get_magic_quotes_gpc()) { $_POST['pass'] = addslashes($_POST['pass']); $_POST['username'] = addslashes($_POST['username']); } // now we insert it into the database $insert = "INSERT INTO members (username, password,Finame, Secname, email) VALUES ('".$_POST['username']."', '".$_POST['pass']."', '".$_POST['Finame']."', '".$_POST['secname']."', '".$_POST['email']."')"; $add_members = mysql_query($insert); ?> <h1>Registered</h1> <p>Thank you, you have registered - you may now login</a>.</p> <A HREf="login.php"">click here to go to login page</a> <?php } else { ?> <form action="<?php echo $_SERVER['PHP_SELF']?>" method="post"> <table border="0"> <tr><td>First name:</td><td> <input type="text" name="name" maxlength="60"> </td></tr> <tr><td>Second name:</td><td> <input type="text" name="sename" maxlength="60"> </td></tr> <tr><td>Username:</td><td> <input type="text" name="username" maxlength="60"> </td></tr> <tr><td>email:</td><td> <input type="text" name="email" maxlength="60"> </td></tr> <tr><td>Password:</td><td> <input type="password" name="pass" maxlength="10"> </td></tr> <tr><td>Confirm Password:</td><td> <input type="password" name="pass2" maxlength="10"> </td></tr> <tr><th colspan=2><input type="submit" name="submit" value="Register"></th></tr> </table> </form> <a href=login.php>Click Here to go to the login page</a><br /> </body></html> <?php } ?> Quote Link to comment https://forums.phpfreaks.com/topic/200652-members-not-being-added/ Share on other sites More sharing options...
Muddy_Funster Posted May 4, 2010 Share Posted May 4, 2010 In your insert statement put a space after the comma before Finame also change $add_members = mysql_query($insert); to mysql_query($insert) or die (mysql_error()); to get error reporting from your SQL. Quote Link to comment https://forums.phpfreaks.com/topic/200652-members-not-being-added/#findComment-1052932 Share on other sites More sharing options...
nhojeinnor Posted May 4, 2010 Share Posted May 4, 2010 Hi i created this code below for user to register up till last night it was working but now it will not add people to my database when they register. Can anyone spot why this would be the case in the code below. I have changed the name of the database, password and host changed names of other things for posting on here. <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html> <head> <meta http-equiv="Content-type" content="text/html;charset=UTF-8"> <meta name="author" content=""> <title>SIGN UP</title> <link rel="stylesheet" type="text/css" href="css1.css" /> </head> <body> <?php error_reporting(0); // Connects to your Database mysql_connect("localhost", "yyyy", "ttt") or die(mysql_error()); mysql_select_db("fg") or die(mysql_error()); //This code runs if the form has been submitted if (isset($_POST['submit'])) { //This makes sure they did not leave any fields blank if (!$_POST['username'] | !$_POST['pass'] | !$_POST['pass2'] ) { die('You did not complete all of the required fields'); } // checks if the username is in use if (!get_magic_quotes_gpc()) { $_POST['username'] = addslashes($_POST['username']); } $usercheck = $_POST['username']; $check = mysql_query("SELECT username FROM members WHERE username = '$usercheck'") or die(mysql_error()); $check2 = mysql_num_rows($check); } // this makes sure both passwords entered match if ($_POST['pass'] != $_POST['pass2']) { die('Your passwords did not match. '); } // here we encrypt the password and add slashes if needed //if the name exists it gives an error if ($check2 != 0) { die('Sorry, the username '.$_POST['username'].' is already in use.'); $_POST['pass'] = md5($_POST['pass']); if (!get_magic_quotes_gpc()) { $_POST['pass'] = addslashes($_POST['pass']); $_POST['username'] = addslashes($_POST['username']); } // now we insert it into the database $insert = "INSERT INTO members (username, password,Finame, Secname, email) VALUES ('".$_POST['username']."', '".$_POST['pass']."', '".$_POST['Finame']."', '".$_POST['secname']."', '".$_POST['email']."')"; $add_members = mysql_query($insert); ?> <h1>Registered</h1> <p>Thank you, you have registered - you may now login</a>.</p> <A HREf="login.php"">click here to go to login page</a> <?php } else { ?> <form action="<?php echo $_SERVER['PHP_SELF']?>" method="post"> <table border="0"> <tr><td>First name:</td><td> <input type="text" name="name" maxlength="60"> </td></tr> <tr><td>Second name:</td><td> <input type="text" name="sename" maxlength="60"> </td></tr> <tr><td>Username:</td><td> <input type="text" name="username" maxlength="60"> </td></tr> <tr><td>email:</td><td> <input type="text" name="email" maxlength="60"> </td></tr> <tr><td>Password:</td><td> <input type="password" name="pass" maxlength="10"> </td></tr> <tr><td>Confirm Password:</td><td> <input type="password" name="pass2" maxlength="10"> </td></tr> <tr><th colspan=2><input type="submit" name="submit" value="Register"></th></tr> </table> </form> <a href=login.php>Click Here to go to the login page</a><br /> </body></html> <?php } ?> $insert = "INSERT INTO members (username, password,Finame, Secname, email) VALUES ('".$_POST['username']."', '".$_POST['pass']."', '".$_POST['Finame']."', '".$_POST['secname']."', '".$_POST['email']."')"; $add_members = mysql_query($insert); try to put ur query on a if else condition together with your $_POST['submit'] value. if($submit){//some input tex} else{ur query} or if(submit){ur query} else{//error message} Quote Link to comment https://forums.phpfreaks.com/topic/200652-members-not-being-added/#findComment-1052933 Share on other sites More sharing options...
heyhey01 Posted May 4, 2010 Author Share Posted May 4, 2010 Thank you for both trying but that did not make a difference Quote Link to comment https://forums.phpfreaks.com/topic/200652-members-not-being-added/#findComment-1052953 Share on other sites More sharing options...
Muddy_Funster Posted May 4, 2010 Share Posted May 4, 2010 Did anything return from the or die(mysql_error()) ? Have you changed any code since it was working? Quote Link to comment https://forums.phpfreaks.com/topic/200652-members-not-being-added/#findComment-1052956 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.