load takes time

[robert_gsfame]

back to previous loop problem, i have this code...but i am not sure why it takes time to load the page

 

<?php

require_once('config.php');

$username="James";

$checkfirstuser=mysql_query(sprintf("SELECT * FROM test WHERE username='%s'",

mysql_real_escape_string($username)));

$i=1;

$tot=0;

while($i==1){

$rand=rand(0,9);

while($checkfirstuserarray=mysql_fetch_array($checkfirstuser)){

$number=$checkfirstuserarray['id'];

if($rand==$number){

$tot++;}

}

if($tot==0){

$i++;}else{}

}

echo $rand;

?>

 

[-Karl-]

"Load takes times". Please be more descriptive.

[robert_gsfame]

i got the warning load exceeds limit  blabla 60 seconds like that...

is there something wrong with the code especially with the loop or if anyone could come up with simple one

 

thx

[robert_gsfame]

Maximum Execution Time Of 60 Seconds Exceeded..

[kenrbnsn]

You're loop is similar to the one I rewrote in your other post.

 

Instead of

<?php
$i=1;
$tot=0;
while($i==1){
$rand=rand(0,9);
while($checkfirstuserarray=mysql_fetch_array($checkfirstuser)){
$number=$checkfirstuserarray['id'];
if($rand==$number){
$tot++;}
}
if($tot==0){
$i++;}else{}
} 
?>

Try

<?php
$checkfirstuserarray=mysql_fetch_assoc($checkfirstuser);
$number=$checkfirstuserarray['id'];
$rand = rand(0,9);
while ($rand == $number) {
    $rand = rand(0,9);
}
echo $rand;
?>

 

BTW, get into the habit of properly indenting your code, it makes reading & debugging code much easier. Also you don't need an "else" clause if there is nothing in it.

 

Ken

[robert_gsfame]

i try the code but the result is not correct

 

i have 3 and 5 inside my database and when using your code, 5 still appear

any loop missing??

[kenrbnsn]

What do you mean by 3 & 5 inside?  Two rows? One row containing two number?

 

Ken

[robert_gsfame]

nope...two rows

James    3

James    5

[kenrbnsn]

Ok, do this:

<?php
$tmp = array();
while($checkfirstuserarray=mysql_fetch_assoc($checkfirstuser)) {
   $tmp[] = $checkfirstuserarray['id'];
}
$rand = rand(0,9);
while (!in_array($rand,$tmp) {
    $rand = rand(0,9);
}
echo $rand;
?>

 

Ken

[robert_gsfame]

Cool!!!Thx kenrbnsn!!