Jump to content

Does this look cocheur?


BradD

Recommended Posts

I'm trying to troubleshoot a problem with a registration form because it just doesn't work and wondering if I should use the if statement this way? I kind of think this is not going to tell me what I need to know. I THINK? it's all coming apart somewhere in this query string???

 

$sql_username_check = mysql_query("SELECT id FROM members WHERE username='$username' LIMIT 1");
          if (!$sql_username_check) {
          die('Invalid id query: ' . mysql_error());
          }

Link to comment
https://forums.phpfreaks.com/topic/205502-does-this-look-cocheur/
Share on other sites

Yes, you can do it that way, but I prefer to use an "or die" clause on the mysql_query() statement itself:

<?php
$q = "SELECT id FROM members WHERE username='$username' LIMIT 1";
$sql_username_check = mysql_query($q) or die("Problem with the query: $q<br>" . mysql_error());
?>

 

Ken

Hmmmm???? I have tried both and neither gives an error message??? But still no data is being INSERTED to that dagnanged database!!!

No Idea where to go from here?

I have tested the INSERT by stripping out all other unnecessary code and that works fine, the if (isset($_POST['username'])){  function is working along with the error message.

 

Is the exit(); function in the right place?

 

I'm lost for ideas at this point.  :wtf:  :wtf:  :wtf:  :'(

 

Could it be my server settings or some settings that I have overlooked?

 

Yes, you can do it that way, but I prefer to use an "or die" clause on the mysql_query() statement itself:

<?php
$q = "SELECT id FROM members WHERE username='$username' LIMIT 1";
$sql_username_check = mysql_query($q) or die("Problem with the query: $q<br>" . mysql_error());
?>

 

Ken

The query is a "select" not a "insert" statement. No data will be inserted with a "select" statement. If there is more code, please post it.

 

Ken

 

Hey Ken:

Here's the thorn in my side.

 

<?php


// Set error message as upon arrival to page   THIS IS WORKING 
$errorMsg = "";

// Check to see if the form has previously been submitted  
if (isset($_POST['username'])){                          // THIS IS WORKING

//Connect to DB
include_once('connectDB.php');                          // THIS IS WORKING 

// Filter the posted variables                       THIS IS WORKING
$firstname = $_POST['firstname']; //mysql_real_escape_string  — 
$lastname = $_POST['lastname']; 
$username = $_POST['username']; 
$password = $_POST['password']; 
$accounttype = $_POST['accounttype'];
$country = $_POST['country']; 
$state = $_POST['state']; 
$city = $_POST['city']; 
$phone = $_POST['phone']; 
$mobile = $_POST['mobile'];
$business = $_POST['business'];
$email = $_POST['email'];
$website = $_POST['website']; 

 // Check to see if the user filled all fields with     THIS IS WORKING 
// the "Required"(*) symbol next to them in the join form
// and print out to them what they have forgotten to put in
if((!$firstname) || (!$lastname) || (!$username)  || (!$password) || (!$email) || (!$accounttype) || (!$country) || (!$state) || (!$city)){

	$errorMsg = "You did not submit the following required information!<br /><br />";
	if(!$firstname){
		$errorMsg .= "--- First Name";
	} else if(!$lastname){
		$errorMsg .= "--- Last Name";
    } else if(!$username){
		$errorMsg .= "--- UserName";
	} else if(!$password){
		$errorMsg .= "--- Password";
	} else if(!$accounttype){
		$errorMsg .= "--- Account Type";
	} else if(!$country){
		$errorMsg .= "--- Country"; 
	} else if(!$state){ 
	    $errorMsg .= "--- State"; 
    } else if(!$city){ 
        $errorMsg .= "--- City"; 
	} else if(!$email){
		$errorMsg .= "--- Email"; 
} else {
// Database duplicate Fields Check         SEEMS TO BREAK DOWN HERE BUT NO ERROR MESSAGES DISPLAY?
$sql_username_check = mysql_query("SELECT id FROM members WHERE username='$username' LIMIT 1");
          if (!$sql_username_check) {
          die('problem with id query: ' . mysql_error());
          }
$sql_email_check = mysql_query("SELECT id FROM `members` WHERE email='$email' LIMIT 1");
          if (!$sql_email_check) {
          die('problem with email query: ' . mysql_error());
          }
$username_check = mysql_num_rows($sql_username_check);
 if (!$username_check) {
          die('problem with num_rows query: ' . mysql_error());
          }
$email_check = mysql_num_rows($sql_email_check); 
if ($username_check > 0){ 
	$errorMsg = "<u>ERROR:</u><br />Your User Name is already in use inside our system. Please try another.";
} else if ($email_check > 0){ 
	$errorMsg = "<u>ERROR:</u><br />Your Email address is already in use inside our system. Please try another.";
} else {

        // Add MD5 Hash to the password variable
       $hashedPass = md5($password); 

        // Add user info into the database table, claim your fields then values 
	$sql = mysql_query("INSERT INTO members (firstname, lastname, username, password, country, state, city, accounttype, phone, mobile, business, email, website)
											 VALUES('$firstname','$lastname','$username','$password','$country','$state','$city','$accounttype','$phone','$mobile','$business','$email','$website')") or die(mysql_error());
  
  // Get the inserted ID here to use in the activation email, 
	$id = mysql_insert_id();
	// Create directory(folder) to hold each user files(pics, MP3s, etc.) 
	mkdir("memberFiles/$id", 0755); 
	// Start assembly of Email Member the activation link
	$to = "$email";
	// My site admin email
	$from = "[email protected]";
        $subject = "Complete your registration";

	//Begin HTML Email Message where you need to change the activation URL inside
	$message = '<html>
	<body bgcolor="#FFFFFF">
	Hi ' . $username . ',
	<br /><br />
	Confirm your registration.
	<br /><br />
	Please click here to activate now >>
	<a href="http://www.mlmnetworkingsystem.com/activation.php?id=' . $id . '">
	ACTIVATE NOW</a>
	<br /><br />
	Your Login Data is as follows: 
	<br /><br />
	E-mail Address: ' . $email . ' <br />
	Password: ' . $password . ' 
	<br /><br /> 
	Thanks! 
	</body>
	</html>';
	// end of message
	$headers = "From: $from\r\n"; // \r opens database read only and \n creates new database truncate old versions if they exist
	$headers .= "Content-type: text/html\r\n";
	$to = "$to";
	// Finally send the activation email to the member
	mail($to, $subject, $message, $headers);
	// Then print a message to the browser for the joiner 
	print "<br /><br /><br /><h4>OK $firstname, one last step to verify your email identity:</h4><br />
	We just sent an Activation link to: $email<br /><br />
	<strong><font color=\"#990000\">Please check your email inbox in a moment</font></strong> to click on the Activation <br />
	Link inside the message. After email activation you can log in.";
	exit(); // Exit so the form and page does not display, just this success message
} // Close else after database duplicate field value checks
  } // Close else after missing vars check
} //Close if $_POST
}

?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Registration</title>
</head>
<body>
  <table width="528" align="center" cellpadding= "4">
  <tr>
  <td width= = "7%">REGISTER AS A MEMBER BELOW </td>
  </tr>
  </table>
  <table width= "528" align= "center" cellpadding= "5">
    <form action="jointoday.php" method="post" enctype="multipart/form-data">
     <tr>
      <td colspan="2"><font color="#FF0000"><?php echo "$errorMsg"; ?></font></td>
    </tr>
    <tr valign="baseline">
      <td nowrap="nowrap" align="right">First Name:</td>
      <td><input name="firstname" type="text" value="<?php echo "$firstname"; ?>" size="40" maxlength="40" /></td> 
    </tr>
    <tr valign="baseline">
      <td nowrap="nowrap" align="right">Last Name:</td>
      <td><input name="lastname" type="text" value="<?php echo "$lastname"; ?>" size="40" maxlength="40" /></td>
    </tr>
    <tr valign="baseline">
      <td nowrap="nowrap" align="right">Username:</td>
      <td><input name="username" type="text" value="<?php echo "$username"; ?>" size="40" maxlength="40" /></td>
    </tr>
    <tr valign="baseline">
      <td nowrap="nowrap" align="right">Password:</td>
      <td><input name="password" type="text" value="<?php echo "$password"; ?>" size="32" maxlength="32" /></td>
    </tr>
     <tr valign="baseline">
      <td align="right">Account Type:</td>
      <td><select name="accounttype">
        <option value="<?php echo "$accounttype"; ?>"><?php echo "$accounttype"; ?></option>
        <option value="a">Normal User</option>
        <option value="b">Expert User</option>
        <option value="c">Super User</option>
      </select></td>
    </tr>
    <tr valign="baseline">
      <td nowrap="nowrap" align="right">Country:</td>
      <td>
        <select name="country" size="1" id="Country">
<option value="<?php echo "$country"; ?>"><?php echo "$country"; ?></option>        
<option value="select a country" selected>(please select a country)</option>
<option value="none">none</option>
<option value="AF">Afghanistan</option>
<option value="AL">Albania</option>
<option value="DZ">Algeria</option>
<option value="AS">American Samoa</option>
<option value="AD">Andorra</option>
<option value="AO">Angola</option>
<option value="AI">Anguilla</option>
<option value="AQ">Antarctica</option>
<option value="AG">Antigua and Barbuda</option>
<option value="AR">Argentina</option>
<option value="AM">Armenia</option>
<option value="AW">Aruba</option>
<option value="AU">Australia</option>
<option value="AT">Austria</option>
<option value="AZ">Azerbaijan</option>
<option value="BS">Bahamas</option>
<option value="BH">Bahrain</option>
<option value="BD">Bangladesh</option>
<option value="BB">Barbados</option>
<option value="BY">Belarus</option>
<option value="BE">Belgium</option>
<option value="BZ">Belize</option>
<option value="BJ">Benin</option>
<option value="BM">Bermuda</option>
<option value="BT">Bhutan</option>
<option value="BO">Bolivia</option>
<option value="BA">Bosnia and Herzegowina</option>
<option value="BW">Botswana</option>
<option value="BV">Bouvet Island</option>
<option value="BR">Brazil</option>
<option value="IO">British Indian Ocean Territory</option>
<option value="BN">Brunei Darussalam</option>
<option value="BG">Bulgaria</option>
<option value="BF">Burkina Faso</option>
<option value="BI">Burundi</option>
<option value="KH">Cambodia</option>
<option value="CM">Cameroon</option>
<option value="CA">Canada</option>
<option value="CV">Cape Verde</option>
<option value="KY">Cayman Islands</option>
<option value="CF">Central African Republic</option>
<option value="TD">Chad</option>
<option value="CL">Chile</option>
<option value="CN">China</option>
<option value="CX">Christmas Island</option>
<option value="CC">Cocos (Keeling) Islands</option>
<option value="CO">Colombia</option>
<option value="KM">Comoros</option>
<option value="CG">Congo</option>
<option value="CD">Congo, the Democratic Republic of the</option>
<option value="CK">Cook Islands</option>
<option value="CR">Costa Rica</option>
<option value="CI">Cote d'Ivoire</option>
<option value="HR">Croatia (Hrvatska)</option>
<option value="CU">Cuba</option>
<option value="CY">Cyprus</option>
<option value="CZ">Czech Republic</option>
<option value="DK">Denmark</option>
<option value="DJ">Djibouti</option>
<option value="DM">Dominica</option>
<option value="DO">Dominican Republic</option>
<option value="TP">East Timor</option>
<option value="EC">Ecuador</option>
<option value="EG">Egypt</option>
<option value="SV">El Salvador</option>
<option value="GQ">Equatorial Guinea</option>
<option value="ER">Eritrea</option>
<option value="EE">Estonia</option>
<option value="ET">Ethiopia</option>
<option value="FK">Falkland Islands (Malvinas)</option>
<option value="FO">Faroe Islands</option>
<option value="FJ">Fiji</option>
<option value="FI">Finland</option>
<option value="FR">France</option>
<option value="FX">France, Metropolitan</option>
<option value="GF">French Guiana</option>
<option value="PF">French Polynesia</option>
<option value="TF">French Southern Territories</option>
<option value="GA">Gabon</option>
<option value="GM">Gambia</option>
<option value="GE">Georgia</option>
<option value="DE">Germany</option>
<option value="GH">Ghana</option>
<option value="GI">Gibraltar</option>
<option value="GR">Greece</option>
<option value="GL">Greenland</option>
<option value="GD">Grenada</option>
<option value="GP">Guadeloupe</option>
<option value="GU">Guam</option>
<option value="GT">Guatemala</option>
<option value="GN">Guinea</option>
<option value="GW">Guinea-Bissau</option>
<option value="GY">Guyana</option>
<option value="HT">Haiti</option>
<option value="HM">Heard and Mc Donald Islands</option>
<option value="VA">Holy See (Vatican City State)</option>
<option value="HN">Honduras</option>
<option value="HK">Hong Kong</option>
<option value="HU">Hungary</option>
<option value="IS">Iceland</option>
<option value="IN">India</option>
<option value="ID">Indonesia</option>
<option value="IR">Iran (Islamic Republic of)</option>
<option value="IQ">Iraq</option>
<option value="IE">Ireland</option>
<option value="IL">Israel</option>
<option value="IT">Italy</option>
<option value="JM">Jamaica</option>
<option value="JP">Japan</option>
<option value="JO">Jordan</option>
<option value="KZ">Kazakhstan</option>
<option value="KE">Kenya</option>
<option value="KI">Kiribati</option>
<option value="KP">Korea, Democratic People's Republic of</option>
<option value="KR">Korea, Republic of</option>
<option value="KW">Kuwait</option>
<option value="KG">Kyrgyzstan</option>
<option value="LA">Lao People's Democratic Republic</option>
<option value="LV">Latvia</option>
<option value="LB">Lebanon</option>
<option value="LS">Lesotho</option>
<option value="LR">Liberia</option>
<option value="LY">Libyan Arab Jamahiriya</option>
<option value="LI">Liechtenstein</option>
<option value="LT">Lithuania</option>
<option value="LU">Luxembourg</option>
<option value="MO">Macau</option>
<option value="MK">Macedonia, The Former Yugoslav Republic of</option>
<option value="MG">Madagascar</option>
<option value="MW">Malawi</option>
<option value="MY">Malaysia</option>
<option value="MV">Maldives</option>
<option value="ML">Mali</option>
<option value="MT">Malta</option>
<option value="MH">Marshall Islands</option>
<option value="MQ">Martinique</option>
<option value="MR">Mauritania</option>
<option value="MU">Mauritius</option>
<option value="YT">Mayotte</option>
<option value="MX">Mexico</option>
<option value="FM">Micronesia, Federated States of</option>
<option value="MD">Moldova, Republic of</option>
<option value="MC">Monaco</option>
<option value="MN">Mongolia</option>
<option value="MS">Montserrat</option>
<option value="MA">Morocco</option>
<option value="MZ">Mozambique</option>
<option value="MM">Myanmar</option>
<option value="NA">Namibia</option>
<option value="NR">Nauru</option>
<option value="NP">Nepal</option>
<option value="NL">Netherlands</option>
<option value="AN">Netherlands Antilles</option>
<option value="NC">New Caledonia</option>
<option value="NZ">New Zealand</option>
<option value="NI">Nicaragua</option>
<option value="NE">Niger</option>
<option value="NG">Nigeria</option>
<option value="NU">Niue</option>
<option value="NF">Norfolk Island</option>
<option value="MP">Northern Mariana Islands</option>
<option value="NO">Norway</option>
<option value="OM">Oman</option>
<option value="PK">Pakistan</option>
<option value="PW">Palau</option>
<option value="PA">Panama</option>
<option value="PG">Papua New Guinea</option>
<option value="PY">Paraguay</option>
<option value="PE">Peru</option>
<option value="PH">Philippines</option>
<option value="PN">Pitcairn</option>
<option value="PL">Poland</option>
<option value="PT">Portugal</option>
<option value="PR">Puerto Rico</option>
<option value="QA">Qatar</option>
<option value="RE">Reunion</option>
<option value="RO">Romania</option>
<option value="RU">Russian Federation</option>
<option value="RW">Rwanda</option>
<option value="KN">Saint Kitts and Nevis</option>
<option value="LC">Saint LUCIA</option>
<option value="VC">Saint Vincent and the Grenadines</option>
<option value="WS">Samoa</option>
<option value="SM">San Marino</option>
<option value="ST">Sao Tome and Principe</option>
<option value="SA">Saudi Arabia</option>
<option value="SN">Senegal</option>
<option value="SC">Seychelles</option>
<option value="SL">Sierra Leone</option>
<option value="SG">Singapore</option>
<option value="SK">Slovakia (Slovak Republic)</option>
<option value="SI">Slovenia</option>
<option value="SB">Solomon Islands</option>
<option value="SO">Somalia</option>
<option value="ZA">South Africa</option>
<option value="GS">South Georgia and the South Sandwich Islands</option>
<option value="ES">Spain</option>
<option value="LK">Sri Lanka</option>
<option value="SH">St. Helena</option>
<option value="PM">St. Pierre and Miquelon</option>
<option value="SD">Sudan</option>
<option value="SR">Suriname</option>
<option value="SJ">Svalbard and Jan Mayen Islands</option>
<option value="SZ">Swaziland</option>
<option value="SE">Sweden</option>
<option value="CH">Switzerland</option>
<option value="SY">Syrian Arab Republic</option>
<option value="TW">Taiwan, Province of China</option>
<option value="TJ">Tajikistan</option>
<option value="TZ">Tanzania, United Republic of</option>
<option value="TH">Thailand</option>
<option value="TG">Togo</option>
<option value="TK">Tokelau</option>
<option value="TO">Tonga</option>
<option value="TT">Trinidad and Tobago</option>
<option value="TN">Tunisia</option>
<option value="TR">Turkey</option>
<option value="TM">Turkmenistan</option>
<option value="TC">Turks and Caicos Islands</option>
<option value="TV">Tuvalu</option>
<option value="UG">Uganda</option>
<option value="UA">Ukraine</option>
<option value="AE">United Arab Emirates</option>
<option value="GB">United Kingdom</option>
<option value="US">United States</option>
<option value="UM">United States Minor Outlying Islands</option>
<option value="UY">Uruguay</option>
<option value="UZ">Uzbekistan</option>
<option value="VU">Vanuatu</option>
<option value="VE">Venezuela</option>
<option value="VN">Viet Nam</option>
<option value="VG">Virgin Islands (British)</option>
<option value="VI">Virgin Islands (U.S.)</option>
<option value="WF">Wallis and Futuna Islands</option>
<option value="EH">Western Sahara</option>
<option value="YE">Yemen</option>
<option value="YU">Yugoslavia</option>
<option value="ZM">Zambia</option>
<option value="ZW">Zimbabwe</option>
        </select></td>
    </tr>
    <tr valign="baseline">
      <td nowrap="nowrap" align="right">State:</td>
      <td><input type="text" name="state" value="<?php echo "$state"; ?>" size="32" /></td>
    </tr>
    <tr valign="baseline">
      <td nowrap="nowrap" align="right">City:</td>
      <td><input type="text" name="city" value="<?php echo "$city"; ?>" size="32" /></td>
    </tr>
    <tr valign="baseline">
      <td nowrap="nowrap" align="right">Phone:</td>
      <td><input type="text" name="phone" value="<?php echo "$phone"; ?>" size="32" /></td>
    </tr>
    <tr valign="baseline">
      <td nowrap="nowrap" align="right">Mobile:</td>
      <td><input type="text" name="mobile" value="<?php echo "$mobile"; ?>" size="32" /></td>
    </tr>
    <tr valign="baseline">
      <td nowrap="nowrap" align="right">Business:</td>
      <td><input type="text" name="business" value="<?php echo "$business"; ?>" size="32" /></td>
    </tr>
    <tr valign="baseline">
      <td nowrap="nowrap" align="right">Email:</td>
      <td><input type="text" name="email" value="<?php echo "$email"; ?>" size="32" /></td>
    </tr>
    <tr valign="baseline">
      <td nowrap="nowrap" align="right">Website:</td>
      <td><input type="text" name="website" value="<?php echo "$website"; ?>" size="32" /></td>
    </tr>
    <tr valign="baseline">
      <td nowrap="nowrap" align="right"> </td>
      <td><input type="submit" name="submit" value="Register" /></td>
    </tr>
      </form>
  </table>
<p> </p>
</body>
</html>

 

Argh Z-Pain, Z-Pain!

I just noticed you already have a thread going on this topic here http://www.phpfreaks.com/forums/index.php/topic,301762.0.html

 

Please don't double post.

 

BTW, check you if/else blocks. I think you have some "}" in the wrong place.

 

Ken

I just noticed you already have a thread going on this topic here http://www.phpfreaks.com/forums/index.php/topic,301762.0.html

 

Please don't double post.

 

BTW, check you if/else blocks. I think you have some "}" in the wrong place.

 

Ken

 

Thanks Ken: I was a bit hesitant to post the code again because I thought that might happen.  I will take a look at the "}"  and see if I can work it out?

cocheur? Given that this post is third result for this word in google, I'd be temptet to say it does look like it.

 

Getting first page organic listings on google is easy... and can be done in short time periods,  it's the php and mysql stuff that is killing me, Im ready to give up, it's been 10 or more days and I still cant get a form to work  :wtf:

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.