code executed when it shouldn't be

[siwelis]

For some reason I have some code like this that executes even when the variable isn't set. Is my syntax wrong?

 

$setting = mysql_real_escape_string($_POST['setting']);
//value posted for setting is "yes"

if($setting = "correct"){
echo Hello;
}

//echo's Hello
//works right



////OTHER SCENARIO



$setting = mysql_real_escape_string($_POST['setting']);
//value is not posted for setting

if($set = "yes"){
echo Hello;
}

//Still echo's Hello

 

I know I could just do a check to see if the variable is set and if not exit() or similar, but I really shouldn't have to... right? I don't mind workarounds, but I'd rather work it through.

 

[PFMaBiSmAd]

One = sign is an assignment operator. Two == signs is a comparison operator.

 

So, yes, your variables are set, with the value on the right-hand side of the = sign, and the if() statements are true at that point.

[KevinM1]

The '=' is the assignment operator.  You want to use '==' in conditionals for equality.

[Pikachu2000]

Yes, the syntax is wrong. You're performing an assignment, rather than a comparison.

 

if( $setting = 'correct' ) has no problem assigning 'corect' to setting, therefore always evaluates as true.

 

if( $setting == 'correct' ) will compare the values.

[siwelis]

if( $setting = 'correct' ) has no problem assigning 'corect' to setting, therefore always evaluates as true.

 

LOL! I'm glad PHP has no problem with that! - Thanks a lot guys! This clears up a LOT of issues I've had.