some help with PHP

[akshay1234]

the following file is /account.php

it returns Parse error: syntax error, unexpected T_ELSE in C:\Program Files\XAMPP\xampp\htdocs\account.php on line 26

basically, when someone without the login cookie navigates here, they should be redirected to login.php.

 

can anyone help me?

<?php
if(isset($_COOKIE["LOGIN"]));
{
$key = 'MY_WORKING_KEY_WHICH_DOES_WORK';
$string = ($_COOKIE['LOGIN']);
$decrypted_username = rtrim(mcrypt_decrypt(MCRYPT_RIJNDAEL_256, md5($key), base64_decode($string), MCRYPT_MODE_CBC, md5(md5($key))), "\0");
    include("/oauth/accounts/$decrypted_username.html");
    echo "<script type=\"text/javascript\">
<!--

if (self != top)
   {
   top.location.href = self.location;href;
   }

//-->
</script>";
}
if(isset($_GET['browse']));
{
$key = 'MY_WORKING_KEY WHICH DOES WORK';
$string = ($_COOKIE['LOGIN']);
$decrypted_username = rtrim(mcrypt_decrypt(MCRYPT_RIJNDAEL_256, md5($key), base64_decode($string), MCRYPT_MODE_CBC, md5(md5($key))), "\0");
    scandir("/oauth/files/$decrypted_username");
    echo "To upload new files, click <a href=\"account.php?upload\">here</a>.";
}else{
    header('Location: /login.html');
}
exit;
?>

[hcdarkmage]

This line:

if(isset($_GET['browse']));

should be

if(isset($_GET['browse'])) //<--NOTICE: No ;

[Rifts]

what about this line

if(isset($_COOKIE["LOGIN"]));

 

remove ; there also?

[hcdarkmage]

I would say Yes.

[akshay1234]

but now, when someone is logged in, and goes to account.php, and it shows you the content of /oauth/accounts/$decrypted_username.html (line 7 of the code). it also displays Warning: Cannot modify header information - headers already sent by (output started at C:\Program Files\XAMPP\xampp\htdocs\oauth\accounts\akshay.html:1) in C:\Program Files\XAMPP\xampp\htdocs\account.php on line 27

 

when someone goes to account.php?browse, it shows you /oauth/accounts/$decrypted_username.html (line 7 of the code), AND asks you if you want to upload files (line 25). no sign of the scandir...

[hcdarkmage]

Two more lines to fix:

include("/oauth/accounts/".$decrypted_username.".html");

and

scandir("/oauth/files/".$decrypted_username);

 

Try that.

 

Also remember to clear your cookies before you test it again. Doing a refresh doesn't always clear that.

[hcdarkmage]

Here, I hope this helps:

if(isset($_COOKIE['LOGIN'])) {
$key = 'MY_WORKING_KEY_WHICH_DOES_WORK';
$string = $_COOKIE['LOGIN'];
$decrypted_username = rtrim(mcrypt_decrypt(MCRYPT_RIJNDAEL_256, md5($key), base64_decode($string), MCRYPT_MODE_CBC, md5(md5($key))), "\0");
    include("/oauth/accounts/".$decrypted_username.".html");
    echo "<script type=\"text/javascript\">
<!--
	if (self != top){
		top.location.href = self.location;href;
	}
//--></script>";
}
if(isset($_GET['browse'])){
$key = 'MY_WORKING_KEY WHICH DOES WORK';
$string = $_COOKIE['LOGIN'];
$decrypted_username = rtrim(mcrypt_decrypt(MCRYPT_RIJNDAEL_256, md5($key), base64_decode($string), MCRYPT_MODE_CBC, md5(md5($key))), "\0");
    scandir("/oauth/files/".$decrypted_username);
    echo "To upload new files, click <a href=\"account.php?upload\">here</a>.";
}else{
    header('Location: /login.html');
}
exit;

[akshay1234]

Parse error: syntax error, unexpected ')' in C:\Program Files\XAMPP\xampp\htdocs\account.php on line 18 shows up

[Rifts]

what is your line 18

[akshay1234]

scandir("/oauth/files/".$decrypted_username.);

is line 18

 

here is my full code:

 

<?php
if(isset($_COOKIE["LOGIN"])) {
$key = 'my_key';
$string = $_COOKIE['LOGIN'];
$decrypted_username = rtrim(mcrypt_decrypt(MCRYPT_RIJNDAEL_256, md5($key), base64_decode($string), MCRYPT_MODE_CBC, md5(md5($key))), "\0");
    include("/oauth/accounts/$decrypted_username.html");
    echo "<script type=\"text/javascript\">
<!--
	if (self != top){
		top.location.href = self.location;href;
	}
//--></script>";
}
if(isset($_GET['browse'])){
$key = 'my_key';
$string = $_COOKIE['LOGIN'];
$decrypted_username = rtrim(mcrypt_decrypt(MCRYPT_RIJNDAEL_256, md5($key), base64_decode($string), MCRYPT_MODE_CBC, md5(md5($key))), "\0");
    scandir("/oauth/files/".$decrypted_username.);
    echo "To upload new files, click <a href=\"account.php?upload\">here</a>.";
    exit;
}else{
    header('Location: /login.html');
}
exit;
?>

 

[hcdarkmage]

Try to do it this way:

$dir = "/oauth/files/".$decrypted_username;
    scandir($dir);

 

Makes me wonder if it doesn't like the break up of the string.

[Pikachu2000]

You have an extra concatenation operator ( . ) after $decrypted_username, before the closing parenthesis.

scandir("/oauth/files/".$decrypted_username.);

[akshay1234]

ok, i redid the code ( a little bit )

 

this one returns unexpected T_else in line 29.

<?php

$jscript = "<script type=\"text/javascript\">
<!--
	if (self != top){
		top.location.href = self.location;href;
	}
//--></script>";
        
if(isset($_COOKIE["LOGIN"])){
        echo $jscript;
}
        if(isset($_GET['browse'])){
                $key = 'myencryptionkey';
                $string = $_COOKIE['LOGIN'];
                $decrypted_username = rtrim(mcrypt_decrypt(MCRYPT_RIJNDAEL_256, md5($key), base64_decode($string), MCRYPT_MODE_CBC, md5(md5($key))), "\0");
                $dir = "/oauth/files/".$decrypted_username;
                scandir($dir);
                echo "To upload new files, click <a href=\"account.php?upload\">here</a>.";
        }
        else
        {
        $key = 'myencryptionkey';
$string = $_COOKIE['LOGIN'];
$decrypted_username = rtrim(mcrypt_decrypt(MCRYPT_RIJNDAEL_256, md5($key), base64_decode($string), MCRYPT_MODE_CBC, md5(md5($key))), "\0");
        include("/oauth/accounts/$decrypted_username.html");
        exit;
        }
else // line 29 is this line
{
    header('Location: /login.html');
}
exit;
?>

 

thank you

any help is appreciated

[trq]

Parse errors are simple syntax errors, you shouldn't really need help finding them.

 

Indent your code consistently and this error in particular will stand out.