Signup check error

[WatsonN]

In my post.php file i have the following code

 // checks if the username is in use
	if (!get_magic_quotes_gpc()) {
		$_POST['username'] = addslashes($_POST['username']);
	}
$usercheck = $_POST['username'];
  	mysql_real_escape_string($usercheck);
$check = mysql_query("SELECT username FROM users WHERE username = '$usercheck'") 
or die(mysql_error());
$check2 = mysql_num_rows($check);

//if the name exists it gives an error
if ($check2 != 0) {
		$error="<span style=";
	$error .="color:red";
	$error .=">";
		$error .= "Sorry, the username is already in use.";
		$error .="</span>";
		setcookie(Errors, $error, time()+20);
	header('Location ./?p=UPC');
	die();
				}

 

The problem is it always 500s if the username is already in use.

[kenrbnsn]

The "location" header should be a URL, not a directory path. It looks like you gave it a directory path and, technically, it needs to be a full URL. You also need a ":" after the word "location".

 

Try something like this:

<?php
header('location: http://' . $_SERVER['HTTP_HOST'] . '?p=UPC');
?>

 

Ken

[WatsonN]

Changed to

header('Location: ./?p=UCP');

but now instead of die() it continues with the script

 

-edit- changed to exit  and halts -edit-

[atrum]

The header runs before die, and tries to redirect to the URL. So die never runs.

 

Also header will assume the hostname if a url is not specified.

 

So something like this

 

 header("Location: /?p=UCP"); 

 

Should work just fine.

 

but

header("Location: ./?p=UCP"); 

 

Won't work.

[WatsonN]

I fixed it by changing it to

exit;