Instead of die?

[mat3000000]

Here is my code... I am using this in HTML and if I put it near my form, the html after this code will not run???

Can someone suggest an alternative to die? (That's if that is the problem, I am guessing it is?!)

        <?php

$username = $_POST['username'];
$password = $_POST['password'];

if ($username=='User Name')
die ("<br /><br /><div align='center' class='errorbox'>Please enter a valid username!</div>");

if ($password=='Password')
die ("<br /><br /><div align='center' class='errorbox'>Please enter a valid password!</div>");

if ($username=='')
die ("<br /><br /><div align='center' class='errorbox'>Please enter a valid username!</div>");

if ($password=='')
die ("<br /><br /><div align='center' class='errorbox'>Please enter a valid password!</div>");




?>

 

 

[trq]

echo.

[Pikachu2000]

Store error messages in an array, then if the array is empty allow the code to proceed, otherwise display the errors, and redisplay the form with the entered values pre-populated so the user can make corrections.

[QuickOldCar]

<?php

$username = $_POST['username'];
$password = $_POST['password'];

if ($username == 'User Name' || ''){
echo ("<br /><br /><div align='center' class='errorbox'>Please enter a valid username!</div>");
echo "<meta http-equiv='refresh' content='5;url=http://somesite.com/somepage.php";
}
if ($password == 'Password' || ''){
echo ("<br /><br /><div align='center' class='errorbox'>Please enter a valid password!</div>");
echo "<meta http-equiv='refresh' content='5;url=http://somesite.com/somepage.php";
}

?>

[QuickOldCar]

Or you can just send them back a page using javascript

 

if ($usename == 'User Name' || '') {
die("You didn't insert a user name."<br /><a href=\"javascript: history.go(-1)\">Click here to try again </a>.");
}

[Pikachu2000]

Surely, you mean:

if ($username == 'User Name' || $username == ''){

[QuickOldCar]

Yes I did, just got up, sorry

[PFMaBiSmAd]

It's also a good idea to validate and display the errors for all of the form fields at once, rather than displaying only the first error found, fix that, resubmit, fix the next error, resubmit...

[QuickOldCar]

the corrected of my mistake above, can also do stuff like adding $checked=0; for each

Then at the end do a

if ($checked == 0){
echo ("<br /><br /><div align='center' class='errorbox'>You didn't properly fill out the form!</div>");
echo "<meta http-equiv='refresh' content='5;url=http://somesite.com/somepage.php";
}

 

<?php

$username = $_POST['username'];
$password = $_POST['password'];

if ($username == 'User Name' || $username == ''){
echo ("<br /><br /><div align='center' class='errorbox'>Please enter a valid username!</div>");
echo "<meta http-equiv='refresh' content='5;url=http://somesite.com/somepage.php";
}
if ($password == 'Password' || $password == ''){
echo ("<br /><br /><div align='center' class='errorbox'>Please enter a valid password!</div>");
echo "<meta http-equiv='refresh' content='5;url=http://somesite.com/somepage.php";
}

?>

[Anti-Moronic]

DIE principle comes to mind in the above. It's really quite simple. Use an errors array, loop through. Also, use a list for errors as it will format a lot better by default.

 

$username = $_POST['username'];
$password = $_POST['password'];

$errors = array();

if($username == 'User Name' || $username == ''){
  $errors[] = 'Please enter a valid username!';
}

if($password == 'Password' || $password == ''){
  $errors[] = 'Please enter a valid password!';
}

$errorHtml = '<ul id="errorlist">';

foreach($errors as $error){
  $errorHtml .= '<li class="errorbox">'.$error.'</li>';
}

$errorHtml .= '</ul>';

echo $errorHtml;

 

Now you can add lots of messages without repeating the same html over and over. Note that I also stored the html in a variable. Sometimes you might not want to echo immediately. Now you can easily include that html any where. You're not using dodgy <br tags to format a list and you can redirect using php if need be because you haven't immediately outputted the html.

[Anti-Moronic]

That would be DRY, by the way. (don't repeat yourself)

[mat3000000]

Thanks for all the help Guys!!! Sorted it now