Mysql Insert error

[MattD00]

I have created a php insert to add data input from a html form into a phpmyadmin database runnig in xxamp.

 

php connect file works fine

<?php
$connect = mysql_connect("localhost","root","") or die("Connection error");

mysql_select_db("ria") or die(mysql_error());

?>

 

php code in insert data into database not working

<?php 
if (isset($_POST['required'])) {
include ('connection.php');

$title = $_POST['title'];
$cost = $_POST['cost'];
$stock = $_POST['no in stock'];
$insert = "INSERT INTO book (title, cost, no in stock) VALUES ('$title', '$cost', '$stock')";

if (!mysqli_query($connect, $insert)) {
 	die('can not insert new record');
}
$newrecord = "New record added";	
															  
}
?>

 

HTML forms

 <form action="Insert.php">

<input type="hidden" name="required" value="true"  />

<fieldset>

<legend>Insert New Book</legend>

<label>Title

<input type="text" name="title" /></label>

<label>Cost

<input type="text" name="cost" /></label>

<label>No. in Stock

<input type="text" name="no in stock" />

</label>

</fieldset>
<br />

<input type="submit" value="Submit" />

</form>

last bit of php to give a message when data has been added

<?php echo $newrecord
?>

 

any suggestions what is wrong with the php.

[Pikachu2000]

Assuming you're getting the 'can not insert new record' error, change it so errors are reported, and the query string is echoed.

 

<?php 
if (isset($_POST['required'])) {
include ('connection.php');
$title = $_POST['title'];
$cost = $_POST['cost'];
$stock = $_POST['no in stock'];
$insert = "INSERT INTO book (title, cost, no in stock) VALUES ('$title', '$cost', '$stock')";
if ( !mysqli_query($connect, $insert) ) {
	die( "<br>Query string: $insert<br>Failed with error: " . mysqli_error($connect) );
} else {
	if( mysqli_affected_rows($connect) > 0 ) {
		$newrecord = "New record added";
	}
}
}
?>

[/code]

[mikosiko]

INSERT INTO book (title, cost, no in stock)

 

is not the error obvious?

[Pikachu2000]

Well, it is to me. I was just hoping to help someone learn to debug

[mikosiko]

@pikachu    I know that you know

[Pikachu2000]

LOL.

[Muddy_Funster]

Once the problem with the PHP is sorted, your then going to get a problem with the actual SQL aswell....Unless everything that you are entering into the database is a number.

 

@Pikachu - Loving that cartoon in your sig!

[MattD00]

I couldn't get any of it to work because i forgot to add method="post" to the html form.

Now that I have the php script will run and i get a

Warning: mysqli_query() expects parameter 1 to be mysqli, resource given in F:\xampp\htdocs\RIA\insert.php on line 18

Warning: mysqli_error() expects parameter 1 to be mysqli, resource given in F:\xampp\htdocs\RIA\insert.php on line 19

 

I tried googling the error but still not sure how to fix it.

[PFMaBiSmAd]

You are using mysql_ functions in your connection code and mysqli_ functions in your main code. You cannot mix mysql_ and mysqli_ on the same connection.

[MattD00]

I have change the mysqli to mysql and the error is still the same.

[PFMaBiSmAd]

Define: change the mysqli to mysql?

 

You cannot just change the name because the parameter list is different. If the error message is exactly the same, then you didn't save the change or you didn't put the new file onto your server.

[MattD00]

Well i saved the file into xxamps htdocs folder.

<?php 
if (isset($_POST['required'])) {
   include ('connection.php');
   $title = $_POST['title'];
   $cost = $_POST['cost'];
   $stock = $_POST['no_in_stock'];
   $insert = "INSERT INTO book (title, cost, no_in_stock) VALUES ('$title', '$cost', '$stock')";
   if ( !mysql_query($connect, $insert) ) {
      die( "<br>Query string: $insert<br>Failed with error: " . mysql_error($connect) );
   } else {
      if( mysql_affected_rows($connect) > 0 ) {
         $newrecord = "New record added";
      }
   }
}
?>

I just got rid of the i on mysqli to make it mysql not sure if that was right or not.

[mikosiko]

mysql_query:

http://php.net/manual/en/function.mysql-query.php

 

mysqli_query:

http://php.net/manual/en/mysqli.query.php

 

different formats