Jump to content

Why does this always echo the same thing?!


ActaNonVerba1

Recommended Posts

	if ($TypeOfPage == 'englandtrinityhouse' || 'welshtrinityhouse' || 'channelislandstrinityhouse'){
	  	$Op = '<input type="text" name="Operator" value="Trinity House" class="Operator">';
}
else {
	if ($TypeOfPage == 'northernlighthouseboard'){
		$Op = '<input type="text" name="Operator" value="Northern Lighthouse Board" class="Operator">';	
	}
	else {
		$Op = '<input type="text" name="Operator" class="Operator">';
	}
}

 

This code always echos the first option when echo'd. Ive checked the var is different each time, eg 'northernlighthouseboard' or 'private'.

 

Anyone care to explain?!

danny

You can't just string together the || 'or' conditions like that. Each must be valid on its own.

 

	if ($TypeOfPage == 'englandtrinityhouse' || $TypeOfPage == 'welshtrinityhouse' || $TypeOfPage == 'channelislandstrinityhouse'){

From a different perspective:

 

/* just in the event case is ALSO an issue */
$TypeOfPage = trim(strtolower($typeOfPage));
/* create an array of values */
$array_one = array("englandtrinityhouse", "welshtrinityhouse", "channelislandstrinityhouse");
$Op = '<input type="text" name="Operator" class="Operator">';
if(in_array($TypeOfPage, $array_one)) {$Op = '<input type="text" name="Operator" value="Trinity House" class="Operator">';}
if($TypeOfPage == 'northernlighthouseboard'){ $Op = '<input type="text" name="Operator" value="Northern Lighthouse Board" class="Operator">';}

You can't just string together the || 'or' conditions like that. Each must be valid on its own.

 

	if ($TypeOfPage == 'englandtrinityhouse' || $TypeOfPage == 'welshtrinityhouse' || $TypeOfPage == 'channelislandstrinityhouse'){

 

Thanks :)

 

To the above, i would use your method but im not 100% confident with arrays yet so do not fully understand it :(

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.