HTML in While Loop

[RAFC_1990]

Hey im quite new to php but im hoping you can help me sort the following code out please.

 

while ($row = mysql_fetch_array($sql_result)) 
{
$id1 = $row["id"];
$username1 = $row["username"];
$password1 = $row["password"];
$organisation1 = $row["organisation"];
$delete = echo '<a href="delete.php<a href="delete.php?id=<?php echo $row->id; ?>">Delete</a>">Delete</a>';

print "<tr><td>$organisation1</td><td></td><td>$username1</td><td>$delete</td></tr>";

 

Im trying to get a delete button at the end of every row, but i cant seem to get the right syntax for it to create the html button and loop it on every row

 

Please could someone help, Thanks.

[kenrbnsn]

You don't want to use the "echo" in an assignment statement. Use

<?php
$delete = "<a href='delete.php?id=$id1'>Delete</a>";
?>

 

Ken

[cs.punk]

You just echo out the variable, no need to add the <?php ?> tags. You only use those if perhaps you've had a closing tag before and your writing static HTML.

 

while ($row = mysql_fetch_array($sql_result)) 
{
$id1 = $row["id"];
$username1 = $row["username"];
$password1 = $row["password"];
$organisation1 = $row["organisation"];
$delete = echo '<a href="delete.php<a href="delete.php?id=' . $row->id . '>Delete</a>">Delete</a>';

print "<tr><td>$organisation1</td><td></td><td>$username1</td><td>$delete</td></tr>";

[cyberRobot]

You just echo out the variable, no need to add the <?php ?> tags. You only use those if perhaps you've had a closing tag before and your writing static HTML.

 

while ($row = mysql_fetch_array($sql_result)) 
{
$id1 = $row["id"];
$username1 = $row["username"];
$password1 = $row["password"];
$organisation1 = $row["organisation"];
$delete = echo '<a href="delete.php<a href="delete.php?id=' . $row->id . '>Delete</a>">Delete</a>';

print "<tr><td>$organisation1</td><td></td><td>$username1</td><td>$delete</td></tr>";

 

 

Note that the above code still has an extra echo that isn't needed. Also, I would imagine that $row->id is an invalid variable. Based on the code, kenrbnsn's solution should work though.

[cyberRobot]

Also, the while loop is missing the end curly bracket after the print statement. Maybe it was accidentally left off when pasting into the forum. But you'll want to look into it if the change provided by kenrbnsn doesn't work.

[RAFC_1990]

Thanks guys, worked a treat.

 

But now the problem is that the delete.php code doesnt seem to work for me

 

if (isset ($_GET['id']) && !empty ($_GET['id'])) {
   mysql_query ('delete from $tbl_name where id='.intval ($_GET['id']).' limit 1');
   header ('Location:adminadd.php');
} else {
   echo ("Error deleting account from database!");
}
exit;

[cyberRobot]

Assuming that you switch to the solution that kenrbnsn mentioned:

 

<?php
...

$delete = "<a href='delete.php?id=$id1'>Delete</a>";

...
?>

 

 

Do the delete links contain the ID? If so, what happens when you try to display $_GET['id'] on delete.php; does an ID get displayed?

[cyberRobot]

Also I should ask, what kind of error are you getting? Does delete.php display "Error deleting account from database!"; are you getting a MySQL error; or something else?

[RAFC_1990]

Yes i used the solution that kenrbnsn mentioned. The link does display the id, but i dont get any error message it just reloads the page as asked but the record is not deleted :/

 

Thanks.

[kenrbnsn]

Then you have to post the code for delete.php

 

Ken

[RAFC_1990]

I did do above, its

 

if (isset ($_GET['id']) && !empty ($_GET['id'])) {
   mysql_query ('delete from $tbl_name where id='.intval ($_GET['id']).' limit 1');
   header ('Location:adminadd.php');
} else {
   echo ("Error deleting account from database!");
}
exit;

[RAFC_1990]

Sorted guys, thanks for your help.