Learning OOP

[3raser]

I just decided to start up on OOP, and it seems quite fun (yes, I find programming fun). But, I'm having trouble on this test OOP page.

 

This is suppose to return the private variable $name, and if it's empty, it's suppose to echo the no name to return message.

 

Code:

 

<?php

class findName
{
private $name;

public function setName($sname)
{
	if(!$sname)
	{
		$this->name = "There is no name to return.";
	}
	else
	{
		$this->name=$sname;
	}
}

public function getName()
{
	return $this->name;
}
}

$n = new findName();
$n->getName();

?>

 

If there is an easier way to do this, please let me now!

 

[KevinM1]

You never call setName, so $name has no value.

[3raser]

New code, still no output:

 

<?php

class findName
{
private $name;

public function setName($sname)
{
	if(!$sname)
	{
		$this->name = "There is no name to return.";
	}
	else
	{
		$this->name=$sname;
	}
}

public function getName()
{
	return $this->name;
}
}

$n = new findName();
$n->setName();
$n->getName();

?>

[KevinM1]

getName RETURNS the value.  It doesn't echo it.

[kenrbnsn]

When I run your code, I get:

Warning: Missing argument 1 for findName::setName(), called in /home/xxxxxx/oop.php on line 26 and defined in /home/xxxxxx/oop.php on line 7

Plus you're not echoing the result.

Try:

<?php

class findName
{
        private $name;

        public function setName($sname='')
        {
                if(!$sname)
                {
                        $this->name = "There is no name to return.";
                }
                else
                {
                        $this->name=$sname;
                }
        }

        public function getName()
        {
                return $this->name;
        }
}

$n = new findName();
$n->setName();
echo $n->getName() . "<br>\n";
?>

 

Ken

[3raser]

When I run your code, I get:

Warning: Missing argument 1 for findName::setName(), called in /home/xxxxxx/oop.php on line 26 and defined in /home/xxxxxx/oop.php on line 7

Plus you're not echoing the result.

Try:

<?php

class findName
{
        private $name;

        public function setName($sname='')
        {
                if(!$sname)
                {
                        $this->name = "There is no name to return.";
                }
                else
                {
                        $this->name=$sname;
                }
        }

        public function getName()
        {
                return $this->name;
        }
}

$n = new findName();
$n->setName();
echo $n->getName() . "<br>\n";
?>

 

Ken

 

Thanks to both, much appreciated.

[ignace]

class MyUsersDao {
    public function findByLastName($lastName) {}
}

 

FindName is not a good name for a class, actions should be methods not objects.